Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jan 2013 at 07:38 UTC
Updated:
16 Mar 2013 at 10:53 UTC
.
| Comment | File | Size | Author |
|---|---|---|---|
| google_data_visualization.zip | 81.92 KB | srutheesh |
Comments
Comment #1
monymirzaHi,
please check the Drupal coding standards and use "Coder" module before pushing your code to Git.
Please fix errors and warnings listed here:
http://ventral.org/pareview/httpgitdrupalorgsandboxsrutheesh1876988git
Comment #2
ykyuen commentedIt would be great if u could provide more information on this issue content. at least the project link instead of just a '.'.
Apart from the problem inside http://ventral.org/pareview/httpgitdrupalorgsandboxsrutheesh1876988git. Please add more @param and @return directives in the comments of each function.
And about the google_data_visualization_help() inside the .module file. i would suggest in a proper format instead of wrapping the whole html snippet in a t() function. here is an example.
Comment #3
ykyuen commentedOne more comment, create a new folder called "templates" in the module root folder and move the google-data-visualization-view.tpl.php to it.
Comment #4
klausiProject 1: #1879654: Google Data Visualization
Project 2: #1879690: Google Data Visualization
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
Comment #4.0
klausiDuplicate can't delete.