.

CommentFileSizeAuthor
google_data_visualization.zip81.92 KBsrutheesh

Comments

monymirza’s picture

Status: Needs review » Needs work

Hi,

please check the Drupal coding standards and use "Coder" module before pushing your code to Git.

Please fix errors and warnings listed here:
http://ventral.org/pareview/httpgitdrupalorgsandboxsrutheesh1876988git

ykyuen’s picture

It would be great if u could provide more information on this issue content. at least the project link instead of just a '.'.

Apart from the problem inside http://ventral.org/pareview/httpgitdrupalorgsandboxsrutheesh1876988git. Please add more @param and @return directives in the comments of each function.

And about the google_data_visualization_help() inside the .module file. i would suggest in a proper format instead of wrapping the whole html snippet in a t() function. here is an example.

  $intro1 = '';
  $intro1 .= 'Google Chart Tools provide a perfect way to visualize data on your website. ';
  $intro1 .= 'From simple line charts to complex hierarchical tree maps, ';
  $intro1 .= 'the chart galley provides a large number of well-designed chart types. ';
  $intro1 .= 'Populating your data is easy using the provided client and server-side tools.';

  $intro2 = 'A chart depends on the following building blocks:';

  $chart_library = '';
  $chart_library .= 'Charts are exposed as JavaScript classes. ';
  $chart_library .= 'Google Chart Tools provides <a href="@url1">many chart types</a> for you to use. ';
  $chart_library .= 'Although the default appearance is best for most situations, ';
  $chart_library .= 'you can easily <a href="@url2">customize a chart</a> to fit the look and feel of your website. ';
  $chart_library .= 'Charts are highly interactive and expose  <a href="@url3">events</a> ';
  $chart_library .= 'that enable you to connect them to create complex <a href="@url4">dashboards</a> ';
  $chart_library .= 'or other experiences <a href="@url5"> integrated with your webpage</a>. ';
  $chart_library .= 'Charts are rendered using HTML5/SVG technology to provide cross-browser compatibility (including VML for older IE versions) ';
  $chart_library .= 'and cross platform portability to iPhones, iPads and Android. No plugins are needed.';
  $chart_library_urls = array(
    '@url1' => 'https://developers.google.com/chart/interactive/docs/gallery',
    '@url2' => 'https://developers.google.com/chart/interactive/docs/customizing_charts',
    '@url3' => 'https://developers.google.com/chart/interactive/docs/events',
    '@url4' => 'https://developers.google.com/chart/interactive/docs/gallery/controls',
    '@url5' => 'https://developers.google.com/chart/interactive/docs/examples#full_html_page_example',
  );

  $datatables = '';
  $datatables .= 'All charts are populated with data using a common JavaScript <a href="@url">DataTable</a> class. ';
  $datatables .= 'Having a common data structure makes it easy to switch between chart types. ';
  $datatables .= 'This class exposes methods for sorting, modifying, and filtering data. ';
  $datatables .= 'You can populate a DataTable programmatically from data that you retrieve from your own database, ';
  $datatables .= 'or you can request data from a data provider that supports the Chart Tools Datasource Protocol.';
  $datatables_url = array(
    '@url' => 'https://developers.google.com/chart/interactive/docs/reference#DataTable',
  );

  $datasources = '';
  $datasources .= 'You can query websites that implement the <a href="@url">Chart Tools Datasource</a> protocol. ';
  $datasources .= 'The Datasource protocol includes a SQL-like query language, ';
  $datasources .= 'and is implemented by Google Spreadsheets and Google Fusion Tables, ';
  $datasources .= 'as well as third party data providers such as SalesForce. ';
  $datasources .= 'You can even implement the protocol on your own website and become a data provider.';
  $datasources_url = array(
    '@url' => 'https://developers.google.com/chart/interactive/docs/queries',
  );

  $output = '';
  $output .= '<div>';
  $output .= '  <h1 class="page-title" itemprop="name">' . t('Introduction to Using Chart Tools.') . '</h1>';
  $output .= '  <p>' . t($intro1) . '</p>';
  $output .= '  <p>' . t($intro2) . '</p>';
  $output .= '  <br/>';
  $output .= '  <h3>' . t('Chart Library') . '</h3>';
  $output .= '  <p>' . t($chart_library, $chart_library_urls) . '</p>';
  $output .= '  <br/>';
  $output .= '  <h3>' . t('DataTables') . '</h3>';
  $output .= '  <p>' . t($datatables, $datatables_url) . '</p>';
  $output .= '  <br/>';
  $output .= '  <h3>' . t('Datasources') . '</h3>';
  $output .= '  <p>' . t($datasources, $datasources_url) . '</p>';
  $output .= '</div>';

  return $output;
ykyuen’s picture

One more comment, create a new folder called "templates" in the module root folder and move the google-data-visualization-view.tpl.php to it.

klausi’s picture

Status: Needs work » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: #1879654: Google Data Visualization
Project 2: #1879690: Google Data Visualization

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

klausi’s picture

Issue summary: View changes

Duplicate can't delete.