Closed (duplicate)
Project:
Edit
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Jan 2013 at 11:21 UTC
Updated:
6 Nov 2014 at 23:55 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
webchickSo we want to do this in a way that doesn't involve a hard requirement on navbar module. Idea for now is exposing a simple, ugly block and then we can work on integration with the core toolbar. We should try and get Jesse's input (who's AFK for a couple of weeks) on this because she spent a bunch of time thinking through this problem which ultimately led to the improved design on the D8 toolbar.
Comment #2
nod_This is now a block in the branch I'm working on.
Comment #3
nod_Postponing until we get a better idea than a block for exposing the edit action.
Comment #4
wim leersA related, but obsolete issue: #1828276: Integrate with the navbar module.
Comment #5
webchickWell, we're going to need a better idea soon. :) You can't actually turn Edit mode on right now at all in Spark.
What do you need to unblock you here? Some of Kevin's time? Jesse's?
Comment #6
webchickAh, ok. So you can turn it on, via the "In-place operations" block on e.g. a full node page:
Good to know, I'll need to add that block to the panels page in Spark.
Still though, that's definitely not optimal. :)
Comment #7
wim leersI think this is blocked on us sitting together and discussing which is the best approach. It's at least technically hard and usability-wise suboptimal to integrate with the Drupal 7 toolbar, but its also suboptimal to force a specific toolbar on those that want to use Edit. So … we'll have to figure out the best (least sucky) middle road.
Comment #8
webchickRoger that. Let's talk about it on the planning call Monday. Will report back here after.
Comment #9
nod_You can now call
edit_trigger_link()to get the a render array that'll output a 'quick edit' link with everything it needs to trigger inline edit.Other Ideas welcome, at least now other modules can easily add this link wherever.
Comment #10
wim leersNice :)
This is about as much as you can do at this point AFAICT.
Comment #11
nod_Demoting, all the pieces are available It's only a matter of knowing how to adjust them now.
Comment #12
nod_NW since we don't have a default way of properly showing the link right now.
Comment #13
wim leersI'm not sure I understand #12…
Related: #1923620: Ability to create arbitrary menu item to trigger edit mode.
Comment #14
zbabtkis commentedWould it make sense to add a a local task to node views? Not a universal solution, but that's been my approach for the website I've been working on. Here's the patch if anyone is interested.
Comment #15
wim leers#12/#13: that's supported by now:
edit_trigger_link(), documented in the >alpha 6 README.#14: Hah, ironically, that's how we made it work in Drupal 8 :)
The problem with that approach is that we limit in-place editing to only sites whose themes support Contextual Links, which are definitely not all of them.
Though, I personally am hugely in favor. Even if only for the fact that it'll simplify maintainability significantly. Curious what others think…
Comment #16
gábor hojtsyI think using the per-entity interaction is superior because it makes people understand what saving will affect. Especially if/once we put in draft states, etc. if the boundaries of the thing being edited are not clear, then how do you know what are you making a draft, etc?
Comment #17
gábor hojtsyComment #18
wim leersI think this is my top priority for next week's D7 day.
Comment #19
wim leersThis will happen, but it is blocked on #1678002: Edit should provide a usable entity-level toolbar for saving fields — once that is committed, we will backport that to the Drupal 7 version of Edit.
Comment #20
wim leersAnd this is definitely critical.
Comment #21
tancLooks like #1678002 is committed, is that ready for backporting?
Comment #22
wim leersA per-entity "Quick edit" link is coming soon now.
Comment #23
wim leersComment #24
wim leersThe Drupal 8 backport (#2111667: Backport Drupal 8's Edit module to Drupal 7) fixed this!
Comment #25
jweirather commentedForgive me if I've missed something obvious, but was there a resolution to this? I'm not seeing the block or the link when viewing the node page, and as such, can only enable edit through contextual links. I'm also not finding the function edit_trigger_link() in code.
Using quickedit 7.x-1.1.
Any guidance appreciated.