I'm the maintainer of the backstretch module.

If interested, I think it makes sense to merge this module into mine. I'll gladly add you as a maintainer if you so desire.

Comments

yannickoo’s picture

yannickoo
Location Berlin
commented

Hey Matt,

I answered this in #1876524: difference with backstretch project ?. I think it would make sense but your module does a complete another thing. I like it that you can control the image via context module but the "view photo" link and the famfamfam icon is a little bit strange but this is my opinion.

ultimateboy’s picture

ultimateboy commented
Status: Active » Closed (works as designed)

Understood. Those are features that I would love to try to improve.

IMO, the difference in approach is manageable. I dont see a reason why we cant have the best of both worlds.

I definitely like the idea of having a field formatter, and it's actually been on my future-plans for my module (at least until I found yours :)

Anyways, if you aren't interested in merging the projects, I understand. I'm definitely going to pull certain things from your module (like the drush download command). Anyways, the invite is always there if you want to help combine the functionality.

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Closed (works as designed) » Active

I have some claims like complying with coding standards. You have lot of errors and you do not have all variables sent via drupal_add_js(array(...), 'setting) in one object, you have for every setting an extra object like: Drupal.settings.backstretchURL, Drupal.settings.backstretchScrollerAdj, Drupal.settings.backstretchScroller, Drupal.settings.backstretchScrollTo.

I think you should fix all these things and then I will take a look and decide whether we can merge our projects or not, okay?

ultimateboy’s picture

ultimateboy commented

Thanks yannickoo.

Most of the syntax issues you linked are pretty simple to solve. The recommendation to merge the Drupal.settings is a good one as well. I'll do what I can.

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Closed (fixed)