When xero_query() fails, this module currently just prints the exception name, without providing any background information about what might have caused the exception or how to resolve it.

The attached patch includes in the error message the items submitted to Xero and Xero's response.

CommentFileSizeAuthor
#1 1880522-improve-xero-error-reporting.patch1.62 KBmradcliffe
xero-exception-parameters-00.patch1.05 KBsmokris

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
StatusFileSize
new 1880522-improve-xero-error-reporting.patch1.62 KB

I don't think printing the entire error in drupal_set_message() is appropriate, but it's definitely useful in watchdog.

Maybe something like this with optional parameter to xero_error() (which should be BC).

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Pushed to 6.x-1.x and 7.x-1.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.