Views aggregation fails

This is a view on the Ubercart uc_order_products table. I'm going for a SUM() on the custom SQL field. So....

Create the View on Ordered products.

Advanced settings, turn on "Use aggregation".

Add some filters.

Add field, the Raw SQL field. Parameter is (uc_order_products.price * uc_order_products.qty). Aggregation setting is SUM.

SQL generated is:

SELECT node_uc_order_products__field_data_field_supplier.field_supplier_value AS node_uc_order_products__field_data_field_supplier_field_supp, MIN(node_uc_order_products.nid) AS node_uc_order_products_nid, 'node' AS field_data_field_supplier_node_entity_type, (uc_order_products.price * uc_order_products.qty) AS raw_sql_field, SUM(uc_order_products.qty) AS uc_order_products_qty
FROM 
{uc_order_products} uc_order_products
LEFT JOIN {uc_orders} uc_orders ON uc_order_products.order_id = uc_orders.order_id
LEFT JOIN {users} users_uc_orders ON uc_orders.uid = users_uc_orders.uid
LEFT JOIN {node} node_uc_order_products ON uc_order_products.nid = node_uc_order_products.nid
INNER JOIN {users_roles} users_uc_orders__users_roles ON users_uc_orders.uid = users_uc_orders__users_roles.uid
LEFT JOIN {node} node ON uc_order_products.nid = node.nid
LEFT JOIN {field_data_field_supplier} node_uc_order_products__field_data_field_supplier ON node_uc_order_products.nid = node_uc_order_products__field_data_field_supplier.entity_id AND (node_uc_order_products__field_data_field_supplier.entity_type = 'node' AND node_uc_order_products__field_data_field_supplier.deleted = '0')
WHERE (( (uc_orders.order_status IN  ('payment_received', 'completed')) AND (users_uc_orders__users_roles.rid = '4') AND (node.type IN  ('book')) ))
GROUP BY field_data_field_supplier_node_entity_type, node_uc_order_products__field_data_field_supplier_field_supp, raw_sql_field
LIMIT 10 OFFSET 0

Note the raw_sql_field in the GROUP BY stuff. As long as it's grouping on that field, a SUM() will never work. Also note that it doesn't do SUM() in the SELECT for the raw_sql_field.

The order_product_qty field, a regular schema field DOES do it correctly. It has a SUM() in the SELECT and nothing in the GROUP BY.

I tried copying in stuff from the parent class query() method, and it seems to work. Try out this patch.

It's all numeric aggregation (not just SUM()), and it relates to the SQL that Views generates, not the SQL entered by the admin setting up a field.

Your instructions say you're applying SUM to the raw SQL field, but your query shows SUM on a different field.

Yes, there's no SUM() on the raw SQL field. There is a GROUP BY, instead, even though I set up the field with SUM aggregation. That's the bug I'm reporting.

Note that, pre-patch, the handler has no use of $this->options['group_type']. That's where it says to use SUM().

I'll see if I can get a simpler view to demonstrate this bug.

I haven't forgotten about this, and will get that sample view...eventually....