Don't manage a vocabulary
olav - October 31, 2007 - 08:01
| Project: | nodeorder |
| Version: | HEAD |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | pvanderspek |
| Status: | active |
Jump to:
Description
With this patch, I make nodeorder cooperate with my taxomenu module which also needs to manage (ie. set vocabulary.module to 'taxomenu').
The approach is to replace the need to set vocabulary.module but rather to maintain the orderable status in a persistent variable for each vocabulary.
--
Olav
| Attachment | Size |
|---|---|
| nodeorder.patch | 4.65 KB |
#1
Olav,
This is a good idea. It brings to light a feature of taxonomy that has been causing me some problems. Take a look at this og_vocab issue where I describe a similar conflict with nodeorder and og_vocab.
I haven't tested your patch yet. The only real reason to set the module for a vocabulary is if you want to implement hook_term_path() -- have you tested to see if nodeorder's hook_term_path is getting called? If it's not, then I think we're gonna need to alter the taxonomy links.
Marc
#2
hook_term_path is the reason I would like to take over vocabulary management. In my application, I use views and panel pages to display ordered node lists. I use nodeorder to order nodes, but not to display them at /nodeorder/... pages.
#3
hook_term_path is used by nodeorder.
#4
What will it take for us to remove our need for orderable vocabularies to be owned by the nodeorder module?
In 6.x, we should be able to alter links pretty easily, so this ought to be possible. I don't think we should consider backporting to 5.x, though.
#5
As far as I can tell, the only reason for modifying the vocabulary-table, is so that hook_term_path is called. This can create conflicts with other modules who want to do the same. There are two alternatives:
- remove the nodeorder/term-page in favor of having users create a page using Views (making Views a required module)
- use hook_link_alter to change the links (which exists since D5 by the way)
Either would be fine by me. Creating a dependency with Views is not really a problem, as I don't think anyone creates a Drupal site without it. On the other hand, using hook_link_alter would work as well although this could create conflicts with other modules just like is the case currently.