If I am not wrong, after disabling all Domain modules and clearing all browser private data, one can still access alfa.example.com and see alfa-specific settings (e.g. header, footer). Maybe it's harmless, I was just surprised.
If I am not wrong, after disabling all Domain modules and clearing all browser private data, one can still access alfa.example.com and see alfa-specific settings (e.g. header, footer). Maybe it's harmless, I was just surprised.
Comments
Comment #1
agentrickardWell that's just some misconceptions, I think.
Seeing alpha.example.com has nothing to do with this module -- that's a server-level configuration.
Browser-private data is not relevant. What is relevant is the data stored in the database. That said, the domain-specific configuration settings should no longer appear when the modules are turned off.
However, if you have page caching turned on, you would need to clear the cache, since the cache for that page might still exist. Perhaps clearing the page cache needs to go into the implementation of hook_uninstall().
Comment #2
agentrickardI think I get it.
If you don't uninstall the module, then the domain_conf table still exists. If it does, you would need to remove the change to settings.php -- otherwise the conf load routine in _domain_conf_load() still runs.
I'll put a 'module_exists' check in that function.
Comment #3
agentrickardmodule_exists will only work is caching is disabled. Try removing the lines from settings.php
Comment #4
skizzo commentedyes: I had nothing in cache, module was disabled, but table was still used... Indeed I don't want/need to remove the module. Maybe this issue should be mentioned in documentation, just in case somebody (with caching) disables the module believing that it is enough, while users are still accessing domains.
Comment #5
agentrickardI added something to the documentation. I think that is a sufficient fix, though I could add a query.
This is a module for advanced users, after all.
But this works, so I'll add it, since it's only one query:
Comment #6
agentrickardCommitted to HEAD.
Comment #7
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.