Reviewed & tested by the community
Project:
Views Datasource
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
6 Jan 2013 at 22:09 UTC
Updated:
13 Feb 2019 at 14:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jec006 commentedI've created an initial patch for this - I think there are some other things that need to get cleaned up, but this at least makes things render correctly (i.e. multiple fields with the 'display in single row' option checked now display in an array.
It appears much of this code wasn't updated for views 3 and so wasn't working properly. I have fixed the issue for each of the outputs, but have really only tested with json.
Comment #2
jec006 commentedHere is a new patch - the old patch seems to fail with a makefile since it edits the info file and drush adds stuff.
Comment #3
cbrasfield commentedThank you!
Comment #4
cbrasfield commentedComment #6
les limResetting status; issues shouldn't be marked as fixed until the patch is committed to the project.
Comment #7
Anonymous (not verified) commentedThanks allot for the patch. Works perfectly. Would be nice to see this committed to the next version.
Comment #8
david.mccandless commented+1 for me on adding the patch to the project. Works great for me. Thanks to jec006 for saving me some time!
Comment #9
cbrasfield commentedEek, apologies for setting the wrong status. This is what I get for not double checking key strokes.
Comment #10
gaele commentedComment #11
gfrenoy commentedThe patch really helped but it was not possible to have 2 times the same field with two different output.
Moreover, I noticed some little glitches in the code (as using undefined variable and wrong copy/past of json function in xml/xhtml/rdf modules.
Just attached a new patch that fixes those problems.
Comment #12
gaele commentedComment #13
likewhoa commentedpatch doesn't seem to do what i was expecting as I am still getting my 'multiple value' link field type to show values on one line i.e
It should really output that image block multiple field as separate sections, something like.
Note this same output of having the fields in one line is also encounter with fieldcollection fields.
Comment #14
likewhoa commentedThis issue might be a duplicate of #1319714: Fields with multiple values are not displayed
Comment #15
liquidcms commentedwondering status of this.. it sounds like a duplicate of #1319714: Fields with multiple values are not displayed but that is marked as closed with fix in alpha2 and this patch predates that rel.
also, i don't think this is fixed in -alpha2
Comment #16
deen1ce commentedThe patch #11 did not apply.
Manual reroll, see attached file
Comment #17
killes@www.drop.org commentedThe patch #11 does not work with field rewriting.
Comment #18
killes@www.drop.org commentedchanging status.
I have a list of nodes with a taxonomy field. There can be more than one term in the field. I need to output both the term name and the term id. To output the id I use rewriting, but this fails with this patch.
Comment #19
killes@www.drop.org commentedI doesn't really work well without the patch: only the first term's ID is shown.
Comment #20
studio-days commented#16 works like a charm. Thanks for this, been searching for ages. For anyone looking, this patch will convert your multi-valued fields into arrays.
Comment #21
jlongbottom commented#16 worked for me as well. thanks!
Comment #22
shelanePatch on #16 is working for me. I hope this can get merged rather quickly since it was an issue reported 4 years ago.
Comment #23
anthonylindsay commentedSo the patch on #16 does turn multiple values into an array, which is great... but if you use grouping (which was just added), it breaks and you get no data returned. It'll need to be re-worked against the latest dev, I'm afraid.
Comment #24
zeip commentedWhat kind of configuration doesn't work with the patch? I'm using it in the most recent VCS version and using both grouping per nid and multiple values works pretty well, except for the issue I patched in #2955990: Grouping adds unnecessary arrays and key to the structure, which still doesn't cause the data to be completely missing. Setting back to Needs review, feel free to change back if the problem still arises.
Comment #25
roadlittledawn commented#16 works for me. nice work! this is going to be super useful for our team. we're exposing our content in json for other external apps in our company to consume. nice to see some dev work around this module to make it even more robust.
Comment #26
zeip commentedA few users have reported this to be working correctly, so moving to RTBC.
Comment #27
zeip commentedThere was a small typo causing the XHTML format to break when using the patch. Attached is a fix for that.