Hi,

i would like to propose small patch which will repair status messages in custom themes:

in function theme_ajax_comments_notify_text we will need to change line:
return '<div id="messages"><div class="clearfix"><div class="messages ajax-comments ' . $status . '"><h2 class="element-invisible">Status message</h2>' . $text . '</div></div></div>';
to:
return theme('status_messages', drupal_set_message($text, $status));

CommentFileSizeAuthor
#3 ajax_comments-status-1881732-3.patch618 bytesttkaminski
#2 ajax_comments-status-1881732.patch615 bytesttkaminski

Comments

tntclaus’s picture

tntclaus commented

This works for me very well. Are there anyone else who tried that patch?

ttkaminski’s picture

ttkaminski commented
StatusFileSize
new ajax_comments-status-1881732.patch615 bytes

I like it. Much cleaner code :) I've attached a patch.

ttkaminski’s picture

ttkaminski commented
StatusFileSize
new ajax_comments-status-1881732-3.patch618 bytes

This line:
return theme('status_messages', drupal_set_message($text, $status));

should be:

drupal_set_message($text, $status);
return theme('status_messages');

There is no need to pass the return value from drupal_set_message to the theme function. The theme function internally gets the messages.

Corrected patch attached.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Status: Needs review » Reviewed & tested by the community

Works for me and is a lot cleaner.

acouch’s picture

acouch commented

Sorry I have been a bad maintainer. I might get some more time for this in the near future, but in case that falls through I posted a request for help on the project homepage.

dr.osd’s picture

dr.osd commented

#3 works fine for version 7.x-1.0-alpha2.
Thanks!

muschpusch’s picture

muschpusch commented
Issue summary: View changes

committed to current dev. Sorry took some time :)

muschpusch’s picture

muschpusch commented
Status: Reviewed & tested by the community » Closed (fixed)