The "label" entity key is not required, but this module assumes that it is present. Field Collection does not provide this key, which creates a fatal error.

[Mon Jan 07 16:19:07 2013] [error] [client 192.168.33.1] PHP Fatal error: Cannot access empty property in /home/vagrant/web/sites/all/modules/security_review/security_review.help.inc on line 294, referer: http://localhost/admin/reports/security-review

I've decided to just use the "id" key for the printed help text for now. Not sure if there's a more logical option.

CommentFileSizeAuthor
#1 security_review-entity_label_key-1882280-1.patch906 byteserikwebb

Comments

erikwebb’s picture

erikwebb commented
StatusFileSize
new security_review-entity_label_key-1882280-1.patch906 bytes
erikwebb’s picture

erikwebb commented
Status: Active » Needs review
coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Fixed

id should be fine for this case. Thanks! Committed http://drupalcode.org/project/security_review.git/commit/bbb5a87

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.