Access denied when viewing revisions that state has been changed without re-saving content

This is really a critical bug if useing revisioning, because it leads to a unnecessary new draft to make a publishd draft visible to guests.

I ran into the same problems. With this bug the module is unusable with revisions. The expected behavior is that after set the state to Published the node is directly visible without the need of a second manipulation and the resulting unnessesary Draft. I think there is a bug with the save functionality while changing the state. Is it possible to get more informations in how the things work internaly there to have it more easy to go into the code and possibly writing a patch?

I made a patch to check and correct the access for anonymous users. After that the behaviour is like expected. Maybe that helps.

There was a error in the patch from comment #3 - here is a better one.

Here is a version of that pacht, that hopefully touches no other permision outside of workbench_moderation.

This patch look good for me. I took a look to the code and it should not touch other permissions. Thx for the work.

Here is a patch version that will only change the permissions if we are in a node/view context - maybe there is a way to nail it down to nodes that are under workbench-moderation only.

corrected patch version due to faild test...

Please create Git patches.

#10: workbench_moderation-access_denied-1883556-10.patch queued for re-testing.

I will provide leonevers patch as a git diff from the dev repo clone of workbench moderation.

thx protractor :-)

Another try with corrected line breaks. Sorry, is also for me the first time I send something here.

Do you have other modules that could have influence to the nodes user access? I tested it with the actual drupal 7 version and Workbench 7.x-1.2 + Workbench Moderation 7.x-1.3+4-dev.

I had the same problem. After running the patch from #17 revisions and workbench works as expected.
Thanks guys great job.

+++ b/workbench_moderation.module
@@ -440,8 +440,25 @@ function workbench_moderation_permission() {
-  if ($op == 'view' && !$node->status && user_access('view all unpublished content', $account)) {
...
+          && $node->status == '0'

"!$node->status" is the same.

+++ b/workbench_moderation.module
@@ -440,8 +440,25 @@ function workbench_moderation_permission() {
+  if(is_object($node) && isset($node->status)){
...
+    ){
...
+    }
...
+    }

code style

+++ b/workbench_moderation.module
@@ -440,8 +440,25 @@ function workbench_moderation_permission() {
+    if( ¶

trailing space

typo fixed

We have the same problem while 'Published' form select on 'Draft' or 'Moderation' page, WM 7.x-1.4. We use one role accessing all transitions where all editors are part of this role.

With the patch non admins see node by alias, no access denied any more. But although it has state published, it doesn't appear for non admins in any content lists as 'Content', 'Workbench' or 'Views'.

And it doesn't solve the issue when changing state to 'Published' by moderation links in views as seen in 'My Drafts' and 'Needs Review' views of Workbench. There we still have access denied.

Only repair access right or disable SQL rewriting in views fix it.

----

Revisioning was interfering: Incompatible with Revisioning module [#1894194] | Drupal.org

The patch #17 worked for me but it also open any nodes to be edited or deleted by any Anonymous users ! Which is a HUGE security issue, even though the permissions were set properly. Is there any other work around this issue ?