Closed (won't fix)
Project:
Private files download permission
Version:
7.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Reporter:
Created:
8 Jan 2013 at 21:15 UTC
Updated:
4 Apr 2020 at 12:15 UTC
Jump to comment: Most recent
Comments
Comment #1
czigor commentedFrom http://drupalcode.org/project/features.git/blob/HEAD:/API.txt:
138 - Using a custom table with a serial ID for identifying configuration objects.
139 If this is the case, you will need to change your schema to use a string
140 identifier / machine name for each object.
141
142 **Features integration:** Fix your schema first, then see below.
Suggestion:
private_files_download_permission_directory: Throw 'did' column out, let 'path' be the primary key.
(One cannot duplicate a path on the UI anyway.)
private_files_download_permission_directory_user:
- Throw 'did' column out, introduce 'path' instead
- Instead of a serial 'duid' we could use a varchar 'duid' created from 'path' + 'uid'
private_files_download_permission_directory_role:
The same as private_files_download_permission_directory_user but instead of 'uid' and 'duid' we have 'rid' and 'drid'.
An uglier but (especially considering upgrade paths) simpler-to-implement solution would be just to add a varchar machine_name column to private_files_download_permission_directory_user and private_files_download_permission_directory_role.
Thoughts? Any chance on this being commited in case of a patch?
Comment #2
zanonmark commentedHi czigor,
I think I don't get the point: could you please explain me what Features actually is, and why would it be useful for this module?
Anyway, the 2.x series will just be maintained from now on. So modifications to the database structure, if any, will be planned for a possible 3.x future release.
Thanks,
Marco
Comment #3
czigor commentedWith Features you can export your configuration into code. This makes development of a site much easier. For example, on code you can use git, while on settings in a db you cannot.
Comment #4
zanonmark commentedComment #5
zanonmark commentedThis would require database modifications and also some time which unfortunately I don't have at the moment.
The issue will be postponed but not closed, though, as a future 3.x version could resume this feature request (there's a similar ticket on the matter).
Thanks,
Marco
Comment #6
zanonmark commentedComment #7
zanonmark commented