Seen at http://qa.drupal.org/pifr/test/305088:

> Use update_sql() instead of db_query() in hook_update_N()

There is no update_sql() in D7.

Comments

jthorson’s picture

Project: Drupal.org infrastructure » Coder
Version: » 6.x-2.x-dev
Component: qa.drupal.org » Review/Rules

Bumping to Coder.

douggreen’s picture

This appears to be fixed in the latest 7.x-2.x version. We are no longer actively supporting the 6.x-2.x version.

I'm wondering how this is done by the d.o. infrastructure, and if we can get you to switch to using the drush plugin (which wouldn't require any setup and teardown of a drupal install) and to switch to the 7.x-2.x version.

jthorson’s picture

I'm at least a few months away from a D7 version of testbot (which was off the plan for quite a while, as we had another alternative that ended up blocked on D7 drupal.org).

The drush plugin approach should certainly be doable, though. I've opened #1904614: Switch Coder operation over to leverage the 'drush' plugin and 7.x-2.x ruleset to track progress.

douggreen’s picture

To install as a plugin

$ cd ~/.drush
$ drush dl coder-7.x-2.x
$ drush install-php-code-sniffer
$ drush coder --style --sniffer --security --sql --i18n --comment --minor <file>

Coder currently has some problems finding files with drush when run from a a valid Drupal install. If you have any problems, use the relative path to DRUPAL_ROOT.

jthorson’s picture

Thanks for the steps! Our challenge will be working that into a new PIFR plugin, and getting the deployment set up on our puppet master server. :)

klausi’s picture

Issue summary: View changes
Status: Active » Closed (won't fix)

Coder for Drupal 6 is now frozen and only security fixes will be applied. Feel free to update this issue and reopen against 7.x-2.x or 8.x-2.x.