Due to multiple problems the ajax for exposed forms does not work.

Steps to reproduce:

  • Add a view with an exposed filter and enable ajax.
CommentFileSizeAuthor
#6 interdiff.txt919 bytesdawehner
#6 drupal-1884176-6.patch4.33 KBdawehner
#5 1884176-5.patch4.12 KBdamiankloip
#5 interdiff.txt2.27 KBdamiankloip
#1 drupal-1884176-1.patch2.03 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new drupal-1884176-1.patch2.03 KB

Blub.

Status: Needs review » Needs work

The last submitted patch, drupal-1884176-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

#1: drupal-1884176-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-1884176-1.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.27 KB
new 1884176-5.patch4.12 KB

I think the patch might have been corrupted. I have added a few basic tests for this. Also, we can remove the ajax logic from views_exposed_form as this is already being added in template_preprocess_views_view with the views.ajax library.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new drupal-1884176-6.patch4.33 KB
new interdiff.txt919 bytes

Just to be sure noone nitpicks about it :)

Status: Needs review » Needs work

The last submitted patch, drupal-1884176-6.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

#6: drupal-1884176-6.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +VDC

Add tag

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Happy with this fix now, and we have test coverage too.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.