Needs review
Project:
D7 Media
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Jan 2013 at 16:32 UTC
Updated:
25 Jan 2019 at 02:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
emattias commentedComment #2
mglamanRe-roll to latest 7.x-2.x
Comment #3
mglamanEr.. didn't mean to RTBC. This is good hack, however Media needs better internal support for passing media information to the form.
Comment #4
pontus_nilssonRe-roll against latest 7.x-2.x.
Comment #5
chris matthews commentedThe 4 year old patch in #4 to media.popups.js does not apply to the latest media 7.x-2.x-dev, but feel free to submit a re-rolled patch and a media maintainer will consider re-opening if you need this and want it reviewed.
Comment #6
mglamanIf a patch no longer applies it Needs Work.
Please review the issue statuses and issue handbook https://www.drupal.org/node/317
Comment #7
chris matthews commentedHi Matt, I'm familiar with the issue statues. joseph.olstad asked me to mark these broken patches as closed outdated. Are you still interested in this patch?
Comment #8
mglamanI am not on the project which requires it anymore. But it is definitely not outdated as a maintainer did not give reasoning why it is a won't fix or not. The case was made that the media file needs to be accessible through extended scripts. It's not outdated purely because the patch doesn't apply (ie: it's not a bug which was fixed elsewhere, unless another issue added this functionality.)
Comment #9
joseph.olstadHere's a re-rolled patch.
I'm not sure why this should be included in a release or not.
A screenshot before patch and after patch is worth 1000 words, or detailed explanation of what this does.
See patch
Comment #10
joseph.olstad