Registration Restriction

Hello aboutblank,

first of all the automatedreview tool gives quite a few coding standard issues:
http://ventral.org/pareview/httpgitdrupalorgsandboxaboutblank1872752git

manual review:

Comments need full stops and need to be descriptive.

It's best to use the drupal equivelent to strlen() and use drupal_strlen() and drupal_substr() instead of substr().

You also want to keep the naming convention consistent so in the README file you'll want to stick to the Registration Restriction title and in implement hook comments you don't need to put the parameters in.

So it would simply be:

/**
 * Implements hook_form_alter().
 */

Hello aboutblank,

Thanks very much for submitting this great module.

Please correct grammar mistake @file registration_restriction.module Line: 63
'description' => 'Settings for restricting user registration to spcified email domains',
spcified to specified

Cheers!

Still have some standards issues.
http://ventral.org/pareview/httpgitdrupalorgsandboxaboutblank1872752git

Hi,

the idea of the module is pretty cool.

A few points from my side:

1)

Warning: This module initializes with no valid emails. If you turn on this
module and do not configure a list of valid email domains, no one will be able
to register for your site!')

I'd rather suggest to set standard value of "Blacklist listed domains" to checked so that there are no side-effects between module activation and configuration.
If you want to keep the logic like this maybe you could think about adding a message indicating that this logic applies. At least the status report should contain it.

2)
The chosen package name "User registration" could be replaced by "Users" which is frequently used also by other modules.

3)
Role "administer users" is used. In some of my projects we do differentiate between administration and daily operations. I would consider the limitation of registrations quite sensitive so I'd rather keep that for admins only with a dedicated role.

Thanks for working on this. Looks really good.

Hello again,

In testing the module itself it seems to work as purposed.

1. There's a missing full stop in the install file doc block.

2. Something that's more of a preference than anything else would be to rename the configuration page title to simple Registration Restriction Settings as it sits nicer and you don't particularly have to state "module" in it's config page title.

I tested the input for potential security vulnerabilities but can safely say in terms of what the user can input there aren't any vulnerabilities.

To me this is RTBC, I guess as it is a small module so it can make the process a whole lot quicker, well done.

http://drupal.org/project/useremaildomain

This sounds like a feature that should live in the existing User Email Domain project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the User Email Domain issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Hello Guys,

I came across this module and corrected few things. I believe this will work in D7 without any issue and also i want to maintain this module for D8.
#13 aboutblank : Could you please grant me to commit the changes.

Regards
Sidhartha

@sidharthap: please post all your changes as patches to http://drupal.org/project/useremaildomain and/or request maintainership there.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.