Found with #1333940-14: Try to use is_file() instead of file_exists() in DrupalKernel::findSitePath() applied

Problem/Motivation

install.core.inc uses the conf dir as $file instead of the $settings_file it should
Causes the requirements message to not be correct.
settingsphpmissing-file-2013-01-09_1824.png
(Ignore the ./ that's probably there for a reason)

Proposed resolution

Use the fillename and path instead of just the path. Should be the same as just getting rid of $file and use $settings_file

Remaining tasks

Remove the "./" at the start of the path names
Reword the last sentence to be similar to other info/error messages of the requirements page.

User interface changes

Before

After

API changes

No API change.

CommentFileSizeAuthor
#25 1884854-25.patch1.27 KBquietone
#25 After.png17.02 KBquietone
#25 Before.png19.11 KBquietone
#12 drupal8.install-settings-requirements.12.patch903 bytesankitgarg
#8 drupal8.install-settings-requirements.8.patch6.43 KBsun
#1 settingsfile-to-s02-2013-01-09_1933.png97.27 KByesct
#1 drupal-file_to_settings_file-1884854-1.patch5.97 KByesct
settingsphpmissing-file-2013-01-09_1824.png119.55 KByesct

Comments

yesct’s picture

yesct commented
Status: Active » Needs review
StatusFileSize
new drupal-file_to_settings_file-1884854-1.patch5.97 KB
new settingsfile-to-s02-2013-01-09_1933.png97.27 KB

Implements removing $file and using $settings_file

With the patch:

settingsfile-to-s02-2013-01-09_1933.png

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Sexy simplification. Someone could have had the brilliant idea back in the days to prepare the t() argument array only once for all, instead of repeating and recreating it all over again with the exact same values. ;)

Status: Needs review » Needs work

The last submitted patch, drupal-file_to_settings_file-1884854-1.patch, failed testing.

yesct’s picture

yesct commented

fail in TaxonomyTermReferenceItemTest? hmm. vijaycs85 was getting random failures in #1879732: Language-related modules not listed on available updates page

yesct’s picture

yesct commented
Status: Needs work » Needs review

#1: drupal-file_to_settings_file-1884854-1.patch queued for re-testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

1: drupal-file_to_settings_file-1884854-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-file_to_settings_file-1884854-1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue summary: View changes
Priority: Minor » Normal
Status: Needs work » Needs review
StatusFileSize
new drupal8.install-settings-requirements.8.patch6.43 KB

How about this?

mgifford’s picture

mgifford
he/him
Primary language English
commented

8: drupal8.install-settings-requirements.8.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I'm encountering these bogus installer UI strings in manual tests of #1757536: Move settings.php to /settings directory, fold sites.php into settings.php

Would be great to move forward here and commit this patch!

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
ankitgarg’s picture

ankitgarg commented
Status: Needs work » Needs review
Issue tags: +SprintWeekend2015
StatusFileSize
new drupal8.install-settings-requirements.12.patch903 bytes

REROLLED.

manningpete’s picture

manningpete commented
Issue tags: -Needs reroll
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work

The patch in #12 seems to have lost some of the logic from #8. Also the indentation is off.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Version: 9.3.x-dev » 9.4.x-dev
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +Bug Smash Initiative
StatusFileSize
new Before.png19.11 KB
new After.png17.02 KB
new 1884854-25.patch1.27 KB

Still valid. I made a new patch and uploaded before and after screenshots. Not running tests until there is agreement on the changes.

quietone’s picture

quietone commented
Status: Needs review » Closed (outdated)

(Ignore the ./ that's probably there for a reason)

I missed that is the Issue Summary. (I need to take a break)

If that is the case there is nothing to do here.

Let's close this as outdated.

If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thanks!