Finalise cardonfile recurring support

+++ b/modules/business/commerce_saferpay_business.moduleundefined
@@ -558,3 +559,58 @@ function commerce_saferpay_business_pay_order($order) {
+  // Create unique payment_redirect_key.
+  $order->data['payment_redirect_key'] = drupal_hash_base64(time());
+  $order->data['payment_method'] = $parent_order->data['payment_method'];

This should not be necessary? This is only used for the credit card form, same for payment_method

+++ b/modules/business/commerce_saferpay_business.moduleundefined
@@ -558,3 +559,58 @@ function commerce_saferpay_business_pay_order($order) {
+  // Copy payment data from the parent order.
+  $order->data['cardonfile_store'] = $parent_order->data['cardonfile_store'];
+  $order->data['payment_method'] = $parent_order->data['payment_method'];
+  $order->data['commerce_saferpay_card_ref_id'] = $parent_order->data['commerce_saferpay_card_ref_id'];
+  $order->data['commerce_saferpay_card_type'] = $parent_order->data['commerce_saferpay_card_type'];
+  $order->data['commerce_saferpay_card_holder'] = $parent_order->data['commerce_saferpay_card_holder'];
+  $order->data['commerce_saferpay_card_number'] = $parent_order->data['commerce_saferpay_card_number'];
+  $order->data['commerce_saferpay_expiry_month'] = $parent_order->data['commerce_saferpay_expiry_month'];
+  $order->data['commerce_saferpay_expiry_year'] = $parent_order->data['commerce_saferpay_expiry_year'];

Shouldn't we use the stored card data here? Meaning that the order should contain a reference to the used card on file id and then we should load that?

All we need for this is the card ref id, everything else should not be duplicated.

+++ b/modules/business/commerce_saferpay_business.moduleundefined
@@ -558,3 +559,58 @@ function commerce_saferpay_business_pay_order($order) {
+  if ($transaction == FALSE) {
+    watchdog('commerce_saferpay_business', 'An error occurred while processing the payment: @error.',
+      array('@error' => commerce_saferpay_business_error()), WATCHDOG_ERROR);
+
+    return FALSE;
...
+  if ($complete_response == FALSE) {
+    watchdog('commerce_saferpay_business', 'An error occurred while settling the payment: @error.',
+      array('@error' => commerce_saferpay_business_error()), WATCHDOG_ERROR);
+
+    return FALSE;

When does this happen? We should probably include a reference to the order that we tried to pay for (maybe use the link option?)

+++ b/modules/business/commerce_saferpay_business.moduleundefined
@@ -558,3 +559,58 @@ function commerce_saferpay_business_pay_order($order) {
+  commerce_order_status_update($order, 'checkout_payment', FALSE, "Payment via Cardonfile");

Not sure if this makes sense (we are not in a checkout process here), what is the state the order is in after the payment? I'd assume this is handled by the recurring framework somehow?

This again, is only used for the checkout process, it tells the payment module which payment the user selected on the previous screen and which should be displayed to the user.

We are already within the payment method call, it is too late to switch to something else now anyway :)

I'd check a module that already implements this, e.g. authorize.net in regards to status change and so on.

I would suggest that we do not copy the data around for now, that we don't actually need. I assume there is a link to the parent order, so you can look it up there if you need to.

Thanks, commited and pushed.