crashes with unknown error what email address has ' such as j.o'brien@somecompany.com

Dont you think the function on line 293 of the user.inc file

function _user_import_existing_uid($email) {

$sql = 'SELECT uid FROM {users} WHERE mail = :mail';
$args = array(':mail' => $email);
$uid = db_query_range($sql, 0, 1, $args)->fetchField();
return $uid;
}

should be replaced with something like this

function _user_import_existing_uid($email) {
//Drupal 7
$uid='';
global $users;
$user=user_load_by_mail($email);
if(!empty($user)){
$uid=$user->uid;
}
return $uid;
}

Try this
email,name,pass
d'monte@someaddress.com,D‰ÛªMonte,Password

I know it's a crazy name but is an actual example of a user name that was in a CSV of 5,00 users that I was given. Whilst I can understand that the there might be an issue the characters is should be normalising the data or at least failing gracefully with some easily understood info for the end user to fix.

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '' for key 'name': INSERT INTO {users} (uid, name, pass, mail, created, status, timezone, init, data) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8); Array ( [:db_insert_placeholder_0] => 11041 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => $S$D4fJC7IXVVU4yBrj/lFeKvideXgI.U8yI9rhLNqSrSfekQbdzkBQ [:db_insert_placeholder_3] => d'monte@someaddress.com [:db_insert_placeholder_4] => 1358643464 [:db_insert_placeholder_5] => 1 [:db_insert_placeholder_6] => -18000 [:db_insert_placeholder_7] => d'monte@someaddress.com [:db_insert_placeholder_8] => a:1:{s:17:"mimemail_textonly";i:0;} ) in drupal_write_record() (line 7106 of /var/www/clients/client3/web42/web/includes/common.inc).

it would also be good if the user Import module could import taxonomy term reverence fields associated with the account

that being said I can manually create a user with the above details so the import user should also be able to do it.

P.S. event though the error says duplicate entry, there is in fact on duplicate entry.

Also regarding user_load_by_mail according the the documentation it only loads the user if found

"A fully-loaded $user object upon successful user load or FALSE if user cannot be loaded."

So I'm not sure of the performance issue you are referring to, also later in the code you go on to use load_user_by_mail so why not here at line 293 and us it once?

Thanks

Bump