Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When a new product display is created an empty 'class' shows up in front of the title of the product variation. Removing it is only possible by opening the 'manage display' of the product display and resaving the 'format settings' of the title(no change is needed).
Comment | File | Size | Author |
---|---|---|---|
#12 | Screenshot-2.jpg | 59.83 KB | drupalreggie |
#4 | title-fix-empty-class-in-title-1885358-4.patch | 1.51 KB | jsacksick |
#3 | title-fix-empty-class-in-title-1885358-3.patch | 520 bytes | jsacksick |
Screen Shot 2013-01-10 at 17.06.17.png | 487.47 KB | sonneworks |
Comments
Comment #1
marktheshark CreditAttribution: marktheshark commentedConfirming issue & solution on my installation.
Comment #2
jsacksick CreditAttribution: jsacksick commentedThis is an issue with the title module, the guilty line is the following :
We have two solutions, either replace the default value of the title_style settings in the
title_field_formatter_info()
declaration or correct the previous check by the following :Comment #3
jsacksick CreditAttribution: jsacksick commentedAttached patch needs review
Comment #4
jsacksick CreditAttribution: jsacksick commentedThis new patch also fixes other isset checks.
Comment #6
sonneworks CreditAttribution: sonneworks commentedtried this on my drupal site and it works, thanks! (the first patch)
Comment #7
plachIsn't this a duplicate of #1885356: Empty HTML class in Linked and wrapped format?
Comment #8
plachReopen if I was wrong in #7.
Comment #9
drupalreggie CreditAttribution: drupalreggie commentedWhat is the best solution for this currently? I'm hoping to launch a production site soon using Commerce Kickstart and this is kind of a major issue.
I've been emulating the demo product variation display settings with my new product variation. This results in some aesthetic improvements but now my product links do not work when it is viewed in a product list.
I'm using commerce kickstart installation profile 7.x 2.0
Comment #10
plachInstall the lastest Title dev.
Comment #11
drupalreggie CreditAttribution: drupalreggie commentedSorry - what / where is the latest title dev? Will this also fix the other display issues;
Comment #12
drupalreggie CreditAttribution: drupalreggie commentedImage
Comment #13
jsacksick CreditAttribution: jsacksick commentedWell the patch from #1885356: Empty HTML class in Linked and wrapped format is for me still incomplete, because the isset check is still there.
$wrap_tag = isset($settings['title_style']) ? $settings['title_style'] : '_none';
The title_style is always set, so the result of the other patch would still be a wrapped tag even if you haven't configured the formatter yet.
--- Edit ---
I've just noticed that weeks later the fix has been commited here #1919640: Empty tag shown when the title field is displayed.