Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
entity system
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2013 at 20:32 UTC
Updated:
29 Jul 2014 at 21:45 UTC
Jump to comment: Most recent file
Comments
Comment #1
larowlanPatch with test demonstrating fail and then fix.
Comment #2
kim.pepperLooks good to me.
Comment #3
jhodgdonNot a documentation issue.
Comment #4
larowlansorry @jhodgdon
Comment #5
webchickThis is somewhat minor, but AFAIK the standard is not to use Exception but instead to specify \Exception where it is used.
Comment #6
webchickCross-post-o-rama!
Comment #7
larowlan@webchick, http://drupalcode.org/project/drupal.git/blob/refs/heads/8.x:/core/lib/D... has 'use Exception', I'm not fussy either way - can change both if you like.
Comment #8
webchickYeah, that's wrong. The reason for that is because if you forget the "use Exception" thing at the top, then basically stuff doesn't work. Since it's not easy to grep for ensuring for every "Exception" there's a corresponding "use Exception", we introduced a standard to prefix it with "\" everywhere so offenders are easier to pick out. This is true for any internal PHP class: See http://drupal.org/node/1353118 under "use"ing classes.
Comment #9
larowlanthanks, again in awe of how you keep all this in your head, new patch fixed both files.
sorry, no interdiff
Comment #11
larowlanrelated #1634442: DatabaseStorageController can't catch exceptions
Comment #12
larowlanNot sure what happened there, fresh re-roll against HEAD.
Comment #13
tim.plunkettLooks sane enough.
Comment #15
tim.plunkettI'm missing something. Hmmm
Comment #16
larowlanmeh, missed one
find and replace fail.
Comment #17
webchickLooks good. Marking back to RTBC so it can be committed once tesbot's done verifying.
Comment #18
sunGood catch.
Can we have a test-only patch to prove the test?
Comment #19
tim.plunkettWait for red/green.
Comment #20
webchickGreat, thanks!
Committed and pushed to 8.x.