kpaxman wrote in #1765422: Date widget format ignored in clientside validation:

I've noticed that date validation fails when text is used instead of numbers, e.g. "Feb 1 2012".

I'm putting together a mapping but this is quite possibly not the best way.

CommentFileSizeAuthor
#8 monthname-1186424-8.patch790 byteskpaxman
#4 clientside_validation_1765422_monthname.patch2.05 KBliam morland
#2 clientside_validation_1765422_monthname.patch735 bytesliam morland
#1 clientside_validation_1765422_monthname.patch695 bytesliam morland

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new clientside_validation_1765422_monthname.patch695 bytes

Fix attached.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new clientside_validation_1765422_monthname.patch735 bytes

Improved patch works with months expressed as numbers or letters.

attiks’s picture

attiks commented
Status: Needs review » Needs work

Thanks for the report and the patch, but I think it will be better if we get a list of months (and a list of abbreviations) from the server (stored in the settings.clientside_validation) so they can get easily translated.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new clientside_validation_1765422_monthname.patch2.05 KB

Updated patch.

attiks’s picture

attiks commented

Looks good, I'll try to run some tests tomorrow and commit this

durum’s picture

durum commented

Any progress on this?

attiks’s picture

attiks commented
Status: Needs review » Fixed

Committed to latest dev version, thanks

kpaxman’s picture

kpaxman commented
Status: Fixed » Needs review
StatusFileSize
new monthname-1186424-8.patch790 bytes

The previous patch(es) fail to resolve this issue. Here's a patch against the latest dev that does.

Note that in actual use I have to combine this with the patch from #1902840 so that it works on dates where the selected month is shorter than the current month.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks @kpaxman.

andyzhang’s picture

andyzhang commented

The validation error message is as the following:
"The value in [field label] is not a valid date.".
I am posting the error message so that the ticket can be searchable by other search engines with the error message.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented

Patch in #8 no longer applies, but it seems to have been fixed already in the latest dev. Can anyone confirm?

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

This has been fixed in the latest dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.