Socialvote

Welcome,

please get a review bonus first. Then try to fix issues raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxfeintears1886348git

Though the CSS coding standards mention this, it is in DRAFT status.

There is consensus on most sections there, but "Alphabetizing properties" is not one of those.

Other logics are acceptable. Consider including a comment to let others know what logic in ordering properties you follow.
This is then the own chosen rule to follow throughout all CSS in your project.

Hello FeintEars and welcome!

Before you proceed, you'll have to check the following review using parreview:
http://ventral.org/pareview/httpgitdrupalorgsandboxfeintears1886348git
To aid you in your following development, install coder and review your code before you commit it :-p

if($pagelink_all != '')
  define('SOCIALVOTE_PAGELINK_ALL', $pagelink_all);
$pagelink_publish = variable_get('socialvote_pagelink_publish', 'publish');
if($pagelink_publish != '')
  define('SOCIALVOTE_PAGELINK_PUBLISH', $pagelink_publish);
$pagelink_notpublish = variable_get('socialvote_pagelink_notpublish', 'notpublish');
if($pagelink_notpublish != '')
  define('SOCIALVOTE_PAGELINK_NOTPUBLISH', $pagelink_notpublish);

Please wrap your if code-blocks using curly brackets ({})

As I can see, you are using a 3rd party library (facebook) which is prohibited, please make use extended api's such as libraries to include 3rd party libraries.
Read the following section before you proceed on implementing 3rd party APIs: http://drupal.org/node/422996

if jquery.json is a 3rd party lib,
then you shouldn't have it unless it is no longer maintained by the original author.

I think you can use the libraries API to detect if that js file is installed/added when installing the module. I'm not exactly sure
Other modules using 3rd party js libraries: wysiwyg with ckeditor. It's worth taking a look on the wysiwyg module for how they add/detect 3rd parth js libraries.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.