Hello guys

A nice feature to have in insert module, might be to enable users to insert images with a link to so it opens up in a shadowbox overlay that displays the original image

CommentFileSizeAuthor
#8 shadowbox-insert_integration-1886464-8.patch3.27 KBmanfer
#7 shadowbox-insert_integration-1886464-7.patch3.68 KBmanfer
#6 shadowbox-insert_integration-1886464-6.patch3.52 KBmanfer
#5 shadowbox-insert_integration-1886464-5.patch1.63 KBmanfer
#4 insert-add_support_to_shadowbox-1886464-4.patch4.09 KB-enzo-
#2 insert-add_support_to_shadowbox-1886464-1.patch4.59 KB-enzo-
#2 insert_shadowbox.png56.57 KB-enzo-
#1 insert-add_support_to_shadowbox-1886464-1.patch4.59 KB-enzo-
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

-enzo-’s picture

-enzo- CreditAttribution: -enzo- commented
FileSize
insert-add_support_to_shadowbox-1886464-1.patch4.59 KB

Attached you can find a a patch to add support to shadowbox

-enzo-’s picture

-enzo- CreditAttribution: -enzo- commented
FileSize
insert_shadowbox.png56.57 KB
insert-add_support_to_shadowbox-1886464-1.patch4.59 KB

Attached you can find a a patch to add support to shadowbox.

New insert styles are added based in Drupal Image Styles as you can see in this image.

Insert with Shadowbox

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Title: Support to shadowbox » Support to add Insert integration for shadowbox
Project: Insert » Shadowbox
Version: 7.x-1.x-dev » 7.x-4.0-beta4
Status: Active » Needs review

Thanks, as is the case with Colorbox and Lightbox2, I'm not adding support for any lightbox-like module directly in Insert. I know Lightbox2 provides support for Insert already, and your patch is already almost perfectly written so it could be a drop-in to Shadowbox module.

It looks like this issue should replace #665208: Add neccessary hooks to work with Insert module, which doesn't have an actual patch attached.

-enzo-’s picture

-enzo- CreditAttribution: -enzo- commented
FileSize
insert-add_support_to_shadowbox-1886464-4.patch4.09 KB

Hello quicksketch

Thanks for you recommendation

Attached now the maintainer can find the patch against shadowbox module

manfer’s picture

manfer CreditAttribution: manfer commented
FileSize
shadowbox-insert_integration-1886464-5.patch1.63 KB

Shadowbox 7.x-4.x is organized in a way that is better to add new funtionality in submodules. So this is my proposed patch

manfer’s picture

manfer CreditAttribution: manfer commented
FileSize
shadowbox-insert_integration-1886464-6.patch3.52 KB

This version works for image and file fields

manfer’s picture

manfer CreditAttribution: manfer commented
FileSize
shadowbox-insert_integration-1886464-7.patch3.68 KB
manfer’s picture

manfer CreditAttribution: manfer commented
FileSize
shadowbox-insert_integration-1886464-8.patch3.27 KB
manfer’s picture

manfer CreditAttribution: manfer commented
Status: Needs review » Fixed

Pushed to 7.x-4.x development version

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

update description

  • Commit d8a39fa on 7.x-4.x, 8.x-1.x by manfer: 
    Issue #1886464 by manfer: insert integration