Notice: Undefined index: symbol in currency_api_get_symbols() (line 298 of

CommentFileSizeAuthor
#5 currency_1887514_01.patch786 bytesxano
#1 currency_1887514_00.patch533 bytesxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: Unassigned » xano
Status: Active » Needs review
StatusFileSize
new currency_1887514_00.patch533 bytes
kaizerking’s picture

kaizerking commented

Thanks it worked

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

It works, but I don't know if this is the right solution. With the array structure used in the 1.x branch, I'm not sure if an unknown value for a currency property should be implemented as a missing array key, or an empty array item.

Needs review from @amateescu.

amateescu’s picture

amateescu commented

I'd say an empty array item :)

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new currency_1887514_01.patch786 bytes

The patch adds default property values, except for the number of decimals, to all currencies.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

@kaizerking: can you test the second patch?

kaizerking’s picture

kaizerking commented

Tested it works

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Notice: Undefined index: symbol in currency_api_get_symbols() (line 298 of » Missing properties in currency definitions
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Assigned: xano » Unassigned