Our hook_mail() defines an email for 'over_threshold', but I don't see this string anywhere else in the module.

Some digging in the older branches & the issue queue may be required to see when this was supported and when it was removed (or whether it was even removed by accident!)

CommentFileSizeAuthor
#2 flag-remove-hook-mail-1888074-2.patch513 bytesalexweber

Comments

giorgio79’s picture

giorgio79 commented

Rules can provide this, so looks unnecessary. :)

alexweber’s picture

alexweber commented
Status: Active » Needs review
StatusFileSize
new flag-remove-hook-mail-1888074-2.patch513 bytes

Confirming that the only other occurrence of even the word "mail" in the entire module is for the "send mail" action which seems to be unrelated.

Simple patch attached to remove this unused hook.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Thanks for checking it's not used.

A 'git log -S'over_threshold'' shows this in the 6x2x branch:

commit 256603f2cd76ddee0b95d4f55ef3d89cbe5e2773
Author: Nathan Haug
Date: Fri Sep 5 17:38:06 2008 +0000

#298846. Improve Actions2 support. Actions support has been moved to a diffe

commit 8fe53815aedcf476331b690c208e3fa7eddc5fb9
Author: Nathan Haug
Date: Sun Jun 15 06:49:38 2008 +0000

#233389 and #270711. Add token and actions support to flag.

The first commit adds a drupal_mail() with that key; the second commit removes it. I am not sure why #298846: Improve Actions2 Support removes it, but it does, so no point keeping the hook_mail().

Committed the patch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.