Currently when setting shared field access we assume that the widgets #access key is always defined. Which may not be true. In this case the field widget is hidden because the !empty() check fails.

CommentFileSizeAuthor
#1 et-fields_hidden-1888192-1.patch1.31 KBplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new et-fields_hidden-1888192-1.patch1.31 KB

This patch adds a check that the #access key is defined and improves the related documentation and readability.

Status: Needs review » Needs work

The last submitted patch, et-fields_hidden-1888192-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review

#1: et-fields_hidden-1888192-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, et-fields_hidden-1888192-1.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Needs review

I can confirm tests fail with latest stable releases of i18n (7.x-1.8) and Variable (7.x-2.2), but pass locally with the latest dev code of both.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Test failures are unrelated to this patch, see #1889084: Menu translation tests broken.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

#1: et-fields_hidden-1888192-1.patch queued for re-testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 72da007 on 7.x-1.x, factory, et-fc, revisions by plach: 
    Issue #1888192 by plach: Fixed Field widgets hidden when no #access key...

  • Commit 72da007 on 7.x-1.x, factory, et-fc, revisions, workbench by plach: 
    Issue #1888192 by plach: Fixed Field widgets hidden when no #access key...