Comments

dawehner’s picture

Assigned: Unassigned » dawehner
Status: Active » Postponed

Working on that once the other issue is in, as this would clash in a lot of places.

dawehner’s picture

Status: Postponed » Needs review
StatusFileSize
new57.96 KB

Let's see.

Status: Needs review » Needs work

The last submitted patch, drupal-1888390-2.patch, failed testing.

dawehner’s picture

Assigned: dawehner » Unassigned
Status: Needs work » Needs review
StatusFileSize
new5.33 KB
new63.29 KB

Ups, forgot some places.

Status: Needs review » Needs work

The last submitted patch, drupal-1888390-4.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new25.67 KB
new84.77 KB

Status: Needs review » Needs work

The last submitted patch, drupal-1888390-6.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new676 bytes
new85.43 KB

There we go, this should fix the remaining parts.

Status: Needs review » Needs work

The last submitted patch, drupal-1888390-8.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new552 bytes
new85.45 KB

There we go, this time it's green.

damiankloip’s picture

#10: drupal-1888390-10.patch queued for re-testing.

damiankloip’s picture

Let's re-test, otherwise this is godo to go.

Status: Needs review » Needs work

The last submitted patch, drupal-1888390-10.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new84.83 KB

Rerolled against some of the recent changes to the views ui controller et al.

Status: Needs review » Needs work

The last submitted patch, 1888390-14.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new84.76 KB

heh, oops.

Status: Needs review » Needs work

The last submitted patch, 1888390-16.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new834 bytes
new85.58 KB

One small bit was left over.

damiankloip’s picture

#18: drupal-1888390-18.patch queued for re-testing.

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

This one is good.

damiankloip’s picture

Issue tags: -VDC

#18: drupal-1888390-18.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +VDC

The last submitted patch, drupal-1888390-18.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new87.42 KB

Needs a bit of a reroll.

Status: Needs review » Needs work

The last submitted patch, 1888390-23.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new1.19 KB
new88.61 KB

Missed a couple.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, 1888390-25.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review

#25: 1888390-25.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, 1888390-25.patch, failed testing.

damiankloip’s picture

StatusFileSize
new3.12 KB
new91.4 KB

Rerolled, and missed after the AjaxDetail.php changes, also missed a couple in the initial reroll.

damiankloip’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1888390-29.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new92.13 KB

Sorry, not sure why there was still a couple of missing switches there. I blame my editor....

Status: Needs review » Needs work

The last submitted patch, 1888390-32.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new88.63 KB

For some odd reasons the patch file contained the old frontpage yml file, let's remove it.

dawehner’s picture

For some odd reasons the patch file contained the old frontpage yml file, let's remove it.

damiankloip’s picture

Wasn't me .... ;)

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community

This was RTBC, just a painful reroll.

olli’s picture

Looks good to me. Maybe we need one cleanup issue for things like function views_page($name, $display_id) and function views_get_view($name).

dawehner’s picture

Well, views_page will be replaced by the route integration anyway, views_get_view would though be helpful.

tim.plunkett’s picture

StatusFileSize
new88.96 KB

Applying patch core/modules/node/config/views.view.frontpage.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.archive.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.backlinks.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.comments_recent.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.glossary.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.taxonomy_term.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.tracker.yml with 1 rejects...
Applying patch core/modules/views/tests/views_test_config/test_views/views.view.test_executable_displays.yml with 1 rejects...
Applying patch core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php with 1 rejects...

The yml ones were just s/human_name/label, the DeleteForm was due to the ConfirmFormBase conversion, that was s/getHumanName()/label()

Status: Reviewed & tested by the community » Needs work

The last submitted patch, vdc-1888390-40.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new88.96 KB

Heh. Here's the interdiff.

diff --git a/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php b/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php
index da2ee02..e36d7ce 100644
--- a/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php
+++ b/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php
@@ -26,7 +26,7 @@ class DeleteForm extends ConfirmFormBase {
    * Implements \Drupal\Core\Form\ConfirmFormBase::getQuestion().
    */
   protected function getQuestion() {
-    return t('Are you sure you want to delete the %name view?', array('%name' => $this->view->label()()));
+    return t('Are you sure you want to delete the %name view?', array('%name' => $this->view->label()));
   }
 
   /**

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
array('%name' => $this->view->label()()))

Looks like lisp/scheme :)

Let's get it in, to not end in endless rerolling

xjm’s picture

Issue tags: -VDC

#42: vdc-1888390-42.patch queued for re-testing.

catch’s picture

#42: vdc-1888390-42.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +VDC

The last submitted patch, vdc-1888390-42.patch, failed testing.

damiankloip’s picture

Status: Needs work » Needs review
StatusFileSize
new89.03 KB

Rerolled.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Let's put this out of its misery

damiankloip’s picture

PLEASE :)

dawehner’s picture

And get back.

webchick’s picture

Title: Change 'human_name' to 'label' and replace View::getHumanName() with View::label() » [Change notice] Change 'human_name' to 'label' and replace View::getHumanName() with View::label()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

This will need a change notice in Views I'm guessing...

chris matthews’s picture

Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.7.x-dev
Component: Code » views.module
Issue summary: View changes

For more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue

chris matthews’s picture

Project: Drupal core » Views (for Drupal 7)
Version: 8.7.x-dev » 7.x-3.x-dev
Component: views.module » Code
Status: Active » Closed (outdated)

Moving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447