Closed (outdated)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jan 2013 at 16:02 UTC
Updated:
4 Apr 2019 at 15:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerWorking on that once the other issue is in, as this would clash in a lot of places.
Comment #2
dawehnerLet's see.
Comment #4
dawehnerUps, forgot some places.
Comment #6
dawehnerComment #8
dawehnerThere we go, this should fix the remaining parts.
Comment #10
dawehnerThere we go, this time it's green.
Comment #11
damiankloip commented#10: drupal-1888390-10.patch queued for re-testing.
Comment #12
damiankloip commentedLet's re-test, otherwise this is godo to go.
Comment #14
damiankloip commentedRerolled against some of the recent changes to the views ui controller et al.
Comment #16
damiankloip commentedheh, oops.
Comment #18
dawehnerOne small bit was left over.
Comment #19
damiankloip commented#18: drupal-1888390-18.patch queued for re-testing.
Comment #20
damiankloip commentedThis one is good.
Comment #21
damiankloip commented#18: drupal-1888390-18.patch queued for re-testing.
Comment #23
damiankloip commentedNeeds a bit of a reroll.
Comment #25
damiankloip commentedMissed a couple.
Comment #27
damiankloip commented#25: 1888390-25.patch queued for re-testing.
Comment #29
damiankloip commentedRerolled, and missed after the AjaxDetail.php changes, also missed a couple in the initial reroll.
Comment #30
damiankloip commentedComment #32
damiankloip commentedSorry, not sure why there was still a couple of missing switches there. I blame my editor....
Comment #34
dawehnerFor some odd reasons the patch file contained the old frontpage yml file, let's remove it.
Comment #35
dawehnerFor some odd reasons the patch file contained the old frontpage yml file, let's remove it.
Comment #36
damiankloip commentedWasn't me .... ;)
Comment #37
damiankloip commentedThis was RTBC, just a painful reroll.
Comment #38
olli commentedLooks good to me. Maybe we need one cleanup issue for things like
function views_page($name, $display_id)andfunction views_get_view($name).Comment #39
dawehnerWell, views_page will be replaced by the route integration anyway, views_get_view would though be helpful.
Comment #40
tim.plunkettApplying patch core/modules/node/config/views.view.frontpage.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.archive.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.backlinks.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.comments_recent.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.glossary.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.taxonomy_term.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.tracker.yml with 1 rejects...
Applying patch core/modules/views/tests/views_test_config/test_views/views.view.test_executable_displays.yml with 1 rejects...
Applying patch core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php with 1 rejects...
The yml ones were just s/human_name/label, the DeleteForm was due to the ConfirmFormBase conversion, that was s/getHumanName()/label()
Comment #42
tim.plunkettHeh. Here's the interdiff.
Comment #43
dawehnerLooks like lisp/scheme :)
Let's get it in, to not end in endless rerolling
Comment #44
xjm#42: vdc-1888390-42.patch queued for re-testing.
Comment #45
catch#42: vdc-1888390-42.patch queued for re-testing.
Comment #47
damiankloip commentedRerolled.
Comment #48
tim.plunkettLet's put this out of its misery
Comment #49
damiankloip commentedPLEASE :)
Comment #50
dawehnerAnd get back.
Comment #51
webchickCommitted and pushed to 8.x. Thanks!
This will need a change notice in Views I'm guessing...
Comment #52
chris matthews commentedFor more information as to why this issue was moved to the Drupal core project, please see issue #3030347: Plan to clean process issue queue
Comment #53
chris matthews commentedMoving back to the contributed Views issue queue and closing as outdated per https://www.drupal.org/project/views/issues/3030347#comment-13023447