Posted by tim.plunkett on January 14, 2013 at 4:02pm
8 followers
| Project: | Views |
| Version: | 8.x-3.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
| Issue tags: | Needs change notification, VDC |
Issue Summary
Similar to #1757564: Change 'name' to 'id' on View entity, we should bring Views inline with the standard entity keys naming.
Comments
#1
Working on that once the other issue is in, as this would clash in a lot of places.
#2
Let's see.
#3
The last submitted patch, drupal-1888390-2.patch, failed testing.
#4
Ups, forgot some places.
#5
The last submitted patch, drupal-1888390-4.patch, failed testing.
#6
#7
The last submitted patch, drupal-1888390-6.patch, failed testing.
#8
There we go, this should fix the remaining parts.
#9
The last submitted patch, drupal-1888390-8.patch, failed testing.
#10
There we go, this time it's green.
#11
#10: drupal-1888390-10.patch queued for re-testing.
#12
Let's re-test, otherwise this is godo to go.
#13
The last submitted patch, drupal-1888390-10.patch, failed testing.
#14
Rerolled against some of the recent changes to the views ui controller et al.
#15
The last submitted patch, 1888390-14.patch, failed testing.
#16
heh, oops.
#17
The last submitted patch, 1888390-16.patch, failed testing.
#18
One small bit was left over.
#19
#18: drupal-1888390-18.patch queued for re-testing.
#20
This one is good.
#21
#18: drupal-1888390-18.patch queued for re-testing.
#22
The last submitted patch, drupal-1888390-18.patch, failed testing.
#23
Needs a bit of a reroll.
#24
The last submitted patch, 1888390-23.patch, failed testing.
#25
Missed a couple.
#26
The last submitted patch, 1888390-25.patch, failed testing.
#27
#25: 1888390-25.patch queued for re-testing.
#28
The last submitted patch, 1888390-25.patch, failed testing.
#29
Rerolled, and missed after the AjaxDetail.php changes, also missed a couple in the initial reroll.
#30
#31
The last submitted patch, 1888390-29.patch, failed testing.
#32
Sorry, not sure why there was still a couple of missing switches there. I blame my editor....
#33
The last submitted patch, 1888390-32.patch, failed testing.
#34
For some odd reasons the patch file contained the old frontpage yml file, let's remove it.
#35
For some odd reasons the patch file contained the old frontpage yml file, let's remove it.
#36
Wasn't me .... ;)
#37
This was RTBC, just a painful reroll.
#38
Looks good to me. Maybe we need one cleanup issue for things like
function views_page($name, $display_id)andfunction views_get_view($name).#39
Well, views_page will be replaced by the route integration anyway, views_get_view would though be helpful.
#40
Applying patch core/modules/node/config/views.view.frontpage.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.archive.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.backlinks.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.comments_recent.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.glossary.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.taxonomy_term.yml with 1 rejects...
Applying patch core/modules/views/config/views.view.tracker.yml with 1 rejects...
Applying patch core/modules/views/tests/views_test_config/test_views/views.view.test_executable_displays.yml with 1 rejects...
Applying patch core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php with 1 rejects...
The yml ones were just s/human_name/label, the DeleteForm was due to the ConfirmFormBase conversion, that was s/getHumanName()/label()
#41
The last submitted patch, vdc-1888390-40.patch, failed testing.
#42
Heh. Here's the interdiff.
diff --git a/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php b/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php
index da2ee02..e36d7ce 100644
--- a/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php
+++ b/core/modules/views/views_ui/lib/Drupal/views_ui/Form/DeleteForm.php
@@ -26,7 +26,7 @@ class DeleteForm extends ConfirmFormBase {
* Implements \Drupal\Core\Form\ConfirmFormBase::getQuestion().
*/
protected function getQuestion() {
- return t('Are you sure you want to delete the %name view?', array('%name' => $this->view->label()()));
+ return t('Are you sure you want to delete the %name view?', array('%name' => $this->view->label()));
}
/**
#43
array('%name' => $this->view->label()()))Looks like lisp/scheme :)
Let's get it in, to not end in endless rerolling
#44
#42: vdc-1888390-42.patch queued for re-testing.
#45
#42: vdc-1888390-42.patch queued for re-testing.
#46
The last submitted patch, vdc-1888390-42.patch, failed testing.
#47
Rerolled.
#48
Let's put this out of its misery
#49
PLEASE :)
#50
And get back.
#51
Committed and pushed to 8.x. Thanks!
This will need a change notice in Views I'm guessing...