The node module allows admins to edit the help text on the node/add/* forms.
This help text is printed via hook_help in the node module.
However, in node_help it wraps the users help text in a P tag.
This is a problem as it is not possible to theme out that p tag and make it something else, and it is possible to enter html as that help text.
So it is possible to add block elements like a UL tag that will be placed inside the P tag, which is invalid markup.
So either the P tag should be a DIV tag, or no tag, or else there should be an easy way to override the p tag to something else.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | before.png | 17.48 KB | utilum |
| #9 | after.png | 17.37 KB | utilum |
| #8 | 1888862-8-before.png | 28.86 KB | star-szr |
| #8 | 1888862-8-after.png | 28.73 KB | star-szr |
| #5 | Remove-p-tag-1888862-5.patch | 781 bytes | enginpost |
Comments
Comment #1
valthebaldI think that's a valid point, and I'd vote for the no wrapper tag at all
Comment #2
valthebaldComment #3
enginpost commented#1: Remove-p-tag-1888862.patch queued for re-testing.
Comment #5
enginpost commentedRerolled the patch
Comment #6
valthebaldLooks fine for me
Comment #7
alexpottWe should at least have screenshots of the change...
Comment #8
star-szr(It would be nice if this and the node description had selectable text formats but that is very out of scope here.)
It feels a bit wrong to me that the help text would be floating in a
<div>unless<p>tags or a<ul>or etc. are specifically added. But from a markup perspective I think this is okay. /node/add does something a bit similar with content type descriptions but each description is part of a definition list and the description ends up wrapper in a<dd>which legally can contain lists and etc. (flow content).In any case, here are screenshots:
Before
After
Edited to add another reference.
Comment #9
utilum commentedI'm not sure what's wrong with the help text "floating in a
<div>"... And the result looks the same to me. Good to go?Before:
After:
Comment #10
valthebaldVisual result should be the same.
Original issue claims to remove unnecessary wrapping of help text with <p>
Comment #11
utilum commented#10 is correct, the visual is different, less space between help text and "Title*" label. I hadn't realised it needs to be identical.
Comment #12
valthebaldNot *that* level of identical. Less space is ok to me
Comment #13
rooby commentedI think less space possibly looks better in this case.
Comment #14
utilum commented#help pis given 10px bottom margin in Seven theme's css. There's no similar rule fordivtags, and that seems sensible.Comment #15
xjm(Merging "node system" and "node.module" components for 8.x; disregard.)
Comment #16
merilainen commentedThe help text already gets a wrapping div, I think this is good to go.
Comment #17
webchickGood catch.
Committed and pushed to 8.x. Thanks!