API page: http://api.drupal.org/api/drupal/developer%21topics%21forms_api_referenc...
It says: "Description: Indicates whether or not button should submit the form."
But should say something along the lines of: "Description: Indicates whether or not the submit handler should be run when the form is submitted using this button."
"submit the form" means: Send the webserver a request.
Which is done whether or not #executes_submit_callback is TRUE or FALSE.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1889030-5-sandykadam-fixed-execute-submit-callback-documentation.patch | 689 bytes | sandykadam |
| #4 | 1889030-1-sandykadam-fixed-execute-submit-callback-description.patch | 688 bytes | sandykadam |
Comments
Comment #1
jhodgdonThanks! Moving to the Documentation project, since the form API reference is in that git repository.
Comment #2
dalinian commentedWow a year later and still hasn't been changed?
Comment #3
jhodgdonIf you would like to make a patch, that would be welcome. No one likes to edit this particular document, so there are a ton of issues and no one makes the patches.
Drupal is a volunteer project. Complaining doesn't really help; doing something does. Thanks!
Comment #4
sandykadam commentedFixed the description in documentation
Comment #5
jhodgdonThanks for the patch!
But I don't think this description is quite correct. The text should only refer to the button where #executes_submit_callback is defined, not "any button".
Comment #6
sandykadam commentedComment #7
sandykadam commented@jhodgdon Fixed the patch as per your suggestion.
Comment #8
jhodgdonThanks, that looks good!
Comment #9
jhodgdonThanks again! Committed to the 6.x, 7.x, and 8.x versions of the form API reference.