Web page address does not turn into link automatically, when the link contains parenthesis.
example: http://en.wikipedia.org/wiki/Insert_(SQL)

CommentFileSizeAuthor
#2 filter-url-paren-188948-2.patch1.85 KBcburschka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Component: comment.module » filter.module

This is a filter issue and has nothing to do with comment.module.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Assigned: Unassigned » cburschka
Status: Active » Needs review
FileSize
filter-url-paren-188948-2.patch1.85 KB

The regular expression that matches URLs does not consider the parenthesis a valid character. I have changed this in the following patch, and the links work, but I haven't exhaustively tested for side effects yet.

grndlvl’s picture

grndlvl CreditAttribution: grndlvl commented
Component: filter.module » comment.module
Status: Needs review » Reviewed & tested by the community

I independently came up with same solution. Submitted patch works.

grndlvl’s picture

grndlvl CreditAttribution: grndlvl commented
Component: comment.module » filter.module

did not mean to change module

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Closed (works as designed)

I think the role of not allowing parenthesis, is to be able to have URLs at end of sidenotes (like this http://...). If the parenthesis is part of the URL, here the closing parenthesis, and even the dot after it (by the looks of the patch) will be part of the URL.

If you check wikipedia pages, they link to URLs such as /wiki/Drop_%28SQL%29