Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When an Ad is marked as Inactive, it is still included in the query to randomly select an ad for that region. So, for example, if you set the region to only display a single random ad, sometimes the inactive ad is selected, which then doesn't display. Basically, the field_ad_status field needs to be included in the original query. Patch forthcoming.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | simpleads_inactive_ads-1889622-1.patch | 845 bytes | mpotter |
Comments
Comment #1
mpotter commentedHere is the patch on 1.8. Should work on dev also.
Comment #2
firfin commentedComment #3
jhodgdonWorks great for me, thanks!
Comment #4
Matthew Kivett commentedDuplicate of this issue is located here: http://drupal.org/node/1947654
This one was here first, but thought it might be good to point anyone interested towards the comments in the other one.
Comment #5
firfin commentedMarked #1947654: Inactive published ads problem as duplicate.
Comment #6
pmusaraj commentedThis patch worked for me as well. It seems to be something that would be a high priority to roll into next release.
Comment #7
dgtlmoon commentedCommitted to 7.x-1.x , does this also affect 7.x-2.x ?
Comment #8
pmusaraj commentedI'm not sure, I was using 1.8. THanks for committing to dev!
Comment #9
jhodgdon7.x-2.x is only released as a -dev, and I doubt too many people are using it on sites. You would probably know better than we would where the equivalent query is being done in your code, so you can check and see if 7x-2.x is affected as well? It's only a 3-lines-changed patch. :)