Pulling SF data into drupal taxonomy terms results in terms with a vid set to 0.

I believe this is because of the way that core taxonomy implements entity classes. See this related case.

In any case, not sure if this is the best long term solution, but I decided to use hook_taxonomy_term_presave in order to avoid inserting a special case in salesforce_pull_process_records. This works when new terms/mapping_objects are created however during update, terms with a vid of 0 are skipped because TaxonomyTermController fails to load them.

CommentFileSizeAuthor
#10 salesforce_pull-term_missing_vid-1889658-10.patch1011 bytesothmen
#8 salesforce_pull-term_missing_vid-1889658-9.patch1.16 KBmèche
#7 salesforce_pull-term_missing_vid-1889658-8.patch1.16 KBmèche
salesforce_pull-term_missing_vid.patch698 bytesmarkisatacomputer

Comments

kostajh’s picture

kostajh commented
Version: 7.x-3.0-alpha2 » 7.x-3.x-dev
Status: Active » Needs review
pianomansam’s picture

pianomansam commented
Status: Needs review » Reviewed & tested by the community

Patch is working for me.

ryan.ryan’s picture

ryan.ryan commented

Patch applied cleanly here.

kostajh’s picture

kostajh commented
Status: Reviewed & tested by the community » Needs work

Thanks for submitting the patch and testing. I'm not sure this is the best way to fix this problem but I am open to committing this in the interim. What do the other maintainers think?

The patch will need to be updated to include a URL to this issue.

seanb’s picture

seanb
Primary language Dutch
Location Netherlands
commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community

This issue is fixed so let's just get this committed?

yogaf’s picture

yogaf commented
Title: Taxonomy Terms pulling without vid » RTBC - Taxonomy Terms pulling without vid

+1 here.
Best way or not this patch is essential for anyone ever mapped a term to salesforce object.

Please commit.

mèche’s picture

mèche commented
StatusFileSize
new salesforce_pull-term_missing_vid-1889658-8.patch1.16 KB

Maybe a better way to this.

mèche’s picture

mèche commented
StatusFileSize
new salesforce_pull-term_missing_vid-1889658-9.patch1.16 KB

Small correction

yogaf’s picture

yogaf commented

Thanks Mèche, patch is working.
Please commit...

othmen’s picture

othmen commented
StatusFileSize
new salesforce_pull-term_missing_vid-1889658-10.patch1011 bytes

This patch salesforce_pull-term_missing_vid-1889658-9.patch can not be applied. I changed it by new one.

othmen’s picture

othmen commented

This latest patch can not be applied. I just recreated it.

vbouchet’s picture

vbouchet
Location Toulouse
commented

This last patch from othmen only change the files path for a proper application via drush make.

  • aaronbauman committed 950366b on 7.x-3.x authored by othmen 
    Issue #1889658 by Mèche, othmen, markisatacomputer: RTBC - Taxonomy...
aaronbauman’s picture

aaronbauman
he/him
commented
Status: Reviewed & tested by the community » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.