Since we now delegate to the config entity storage controller there no longer is any need to create manifest entries in config_install_default_config().
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 4-9-interdiff.txt | 459 bytes | alexpott |
| #9 | 1889752.9.drupal8.manifest.patch | 5.63 KB | alexpott |
| #4 | 3-4-interdiff.txt | 1.07 KB | alexpott |
| #4 | 1889752.4.drupal8.manifest.patch | 5.02 KB | alexpott |
| #3 | 1-3-interdiff.txt | 3.98 KB | alexpott |
Comments
Comment #1
alexpottHere's a patch that adds a test to ensure manifests are written for config entities and removes the unnecessary code - which was made unnecessary due to #1806178: Remove code duplication for hook_config_import_*() implementations of config entities.
Comment #2
gddI think we always want to have a manifest file even when it is empty, and right now there will be no manifest if a module is installed with no default config entities out of the box. So I'd like to see an empty manifest file created in config_install_default_config() for consistency's sake. Otherwise this is a great changed, that original code was pretty ugly, I'm glad to see it go.
Comment #3
alexpottNew patch that ensures an empty manifest is created for each config entity whether or not a default config entity is provided. Tests added for this too.
Comment #4
alexpottActually we want to create empty manifest files even if the module has no config directory!
Comment #6
alexpott#4: 1889752.4.drupal8.manifest.patch queued for re-testing.
Comment #7
alexpottGot a fatal php error in testRegression_310447() - nought to do with this change - so requested retest.
Comment #9
alexpottoh wow! the fatal is caused by this patch ...
So when installing the 'database_test' module simpletest thinks it's got node installed but actually it hasn't... funnily enough this test does not even need node installed.
Comment #10
alexpott#9: 1889752.9.drupal8.manifest.patch queued for re-testing.
Comment #11
sunThanks!
Comment #12
webchickCommitted and pushed to 8.x. Thanks!