Title says it all really, see patch.

CommentFileSizeAuthor
#9 poll_1_248_patch05.txt1.43 KBAjK
#5 poll_1_248_patch04.txt1.53 KBAjK
#3 poll_1_248_patch02.txt1.39 KBAjK
poll_1_248_patch01.txt1.35 KBAjK

Comments

grndlvl’s picture

grndlvl commented
Status: Needs review » Reviewed & tested by the community

Patch works.

AjK’s picture

AjK commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new poll_1_248_patch02.txt1.39 KB

Missed actually checking the node is owned by the current user

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Patch has issues (and DOS linebreaks).

patch -p0 < poll_1_248_patch02.txt 
(Stripping trailing CRs from patch.)
patching file modules/poll/poll.module
patch unexpectedly ends in middle of line
Hunk #2 succeeded at 182 with fuzz 1.

Does apply though.

Occurs to me that you also need an 'edit polls' permission, like other node types, for admins.

AjK’s picture

AjK commented
StatusFileSize
new poll_1_248_patch04.txt1.53 KB

Add "edit polls" as per #4

catch’s picture

catch
he/him
Primary language English
commented

ronseal issue. RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

Coding style issue in patch with function indentation.

AjK’s picture

AjK commented
Status: Needs work » Needs review
StatusFileSize
new poll_1_248_patch05.txt1.43 KB

Doh

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Thanks, committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.