hook_libraris_info() need update refer to latest Colorbox plugins [#1890116]

Latest colorbox plugins has the version number on line 2, See patch

diff -ur colorbox/colorbox.module ../custom/colorbox/colorbox.module
--- colorbox/colorbox.module	2013-01-16 19:43:40.000000000 +0700
+++ ../custom/colorbox/colorbox.module	2013-01-16 19:43:11.000000000 +0700
@@ -82,7 +82,7 @@
     'version arguments' => array(
       'file' => 'colorbox/jquery.colorbox-min.js',
       'pattern' => '@ColorBox v([0-9\.a-z]+)@',
-      'lines' => 1,
+      'lines' => 2,
     ),
     'files' => array(
       'js' => array(

Comment	File	Size	Author
#4	patch-colorbox-1_3_21-2.patch	496 bytes	jamesHF
#1	patch-colorbox-1_3_21.patch	407 bytes	geoffreyr

Comments

Status	File	Size
new	patch-colorbox-1_3_21.patch	407 bytes

Comment #2

frjo commented 17 January 2013 at 00:31

Version:	7.x-2.0	» 7.x-2.x-dev
Assigned:	Unassigned	» frjo

The directory structure have changed as well so more chages was needed.

I have committed fixes to 7.x-2.x-dev as well as 7.x-1.x-dev.

Please test and report back here if it works for you.

When I have received a couple of positive responses I will make new stable releases.

Comment #3

aendra commented 17 January 2013 at 12:51

Confirming that the latest dev snapshot fixes the issue on my install. Thanks, frjo!

Comment #4

jamesHF commented 17 January 2013 at 19:40

Status	File	Size
new	patch-colorbox-1_3_21-2.patch	496 bytes

For me, I also had to remove the extra 'colorbox/' from the path to make it work. (Working on 7.x-2.0 instead of dev)

Comment #5

jmoruzi

Brantford, ON

commented 17 January 2013 at 20:12

Latest dev fixed this issue for me as well, thanks frjo!

Contrary to what some other threads are saying, you DO NOT need multiple nested colorbox folders, sites/all/libraries/colorbox/jquery.colorbox-min.js works.

Comment #6

bisonbleu commented 17 January 2013 at 21:29

New dev release works for me. Thanks!

Comment #7

frjo commented 18 January 2013 at 05:07

Version:

7.x-2.x-dev

» 7.x-1.x-dev

Version 7.x-2.1 is out.

Could you please confirm that the fix in 7.x-1.x works as well?

Comment #8

bisonbleu commented 19 January 2013 at 22:24

I've disabled 7.x-2.x-dev, downloaded & installed 7.x-1.x-dev. Colorbox slideshow doesn't work and I get the following error.

Notice : Undefined index: minified in colorbox_get_js() (line 304 in /Applications/MAMP/htdocs/zamorg2/sites/all/modules/colorbox/colorbox.module).

Also tried with 7.x-2.1. Colorbox slideshow works but I get the following error.

Notice : Undefined property: stdClass::$nid in colorbox_handler_field_colorbox->render() (line 189 in /Applications/MAMP/htdocs/zamorg2/sites/all/modules/colorbox/views/colorbox_handler_field_colorbox.inc).

Back to 7.x-2.x-dev. Works. :-)

Comment #9

frjo commented 20 January 2013 at 04:03

@bisonbleu, when reverting from 7.x-2.x back to 7.x-1.x you need to first uninstall 7.x-2.x. Some settings conflict and results in the errors you was seeing.

The "nid" error for colorbox_handler_field_colorbox() has been fixed in 7.x-2.x-dev as you noticed:

#1891780: Undefined property: stdClass::$nid in colorbox_handler_field_colorbox->render()