This patch (untested) attempts to do two things:

a) Link to first unread follow-up if it exists; if not, use the existing 'most recent follow-up' link.
b) Wraps the link names in t() so they are translatable.

CommentFileSizeAuthor
#5 first_unread.patch1.87 KBhunmonk
#4 patch.txt1.11 KBwebchick
#3 patch.txt882 byteswebernet
#1 project_issue-first-unread-link-189075-1.patch2.37 KBwebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new project_issue-first-unread-link-189075-1.patch2.37 KB

Patch.

hunmonk’s picture

hunmonk commented
Status: Needs review » Fixed

committed to HEAD, applied on drupal.org, with a small correction.

webernet’s picture

webernet commented
Status: Fixed » Needs review
StatusFileSize
new patch.txt882 bytes

Small fix for a bug spotted by hunmonk. The link to #new was shown even if there wasn't a #new to link to.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new patch.txt1.11 KB

Patch is exactly the same, but fixes a small indentation error I noticed from the very first patch.

Unfortunately, I don't have a way to test, but I think it should work.

hunmonk’s picture

hunmonk commented
StatusFileSize
new first_unread.patch1.87 KB

this doesn't quite do it. we need to use the timestamp of the most recent comment for an accurate test. also, we decided that if a node has never been viewed before, that neither of the recent links should be displayed.

attached corrects.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Hunmonk and I tested several conditions on project.drupal.org:

- New node I never viewed before, confirmed that only "post a follow-up" appeared.
- Edited comment on a node, confirmed that no new links appeared.
- Confirmed old behaviour (jump to most recent, jump to first unread) continued to work as expected.

RTBC. :)

hunmonk’s picture

hunmonk commented
Status: Reviewed & tested by the community » Fixed

committed to HEAD, installed on drupal.org

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.