Problem/Motivation

Usability testing showed participants thought there was something wrong with the module they were wanting to enable because of the red warningish disabled word.

Proposed resolution

A) remove red from "required by". use red only for "requires" to alert those need to also be enabled.
B) remove red from both. Since dependencies are added automatically, and listed on a confirmation page, users do NOT need to check the checkboxes for dependencies.
C) ?
D) won't fix. it's fine.

Remaining tasks

  • Discuss.
  • Do more user testing?
  • Link to the issue that picked putting the red disabled word there.
  • find issue to rework the modules page in general

User interface changes

TBD. red-disabled-2013-01-17_0536.png

API changes

No API changes.

Original report in User testing report

http://groups.drupal.org/node/271918 under task 1

Our beginner read each module description and noted the Language module description was way long. Opening down the description (because it did not fit the length of the screen), exclaimed: "Now what is wrong with this?" seeing the red "disabled" notices along modules dependent on Language)

Comments

yesct’s picture

Issue tags: +budapest2012
mitron’s picture

Red suggests an error or problem. A required or a disabled module is neither and error or a problem.

The red should be removed in both places.

dodorama’s picture

I agree with Mitron, the red should be removed in both cases. We could use emphasis or bold but I would just keep it in plain text.
Especially because if you try to activate a module that requires another one drupal will ask you to auto activate it.

mitron’s picture

It appears there are possibly four relevant colors in the system.admin.css:

div.admin-requirements,
div.admin-required {
font-size: 0.9em;
color: #666;
}
span.admin-disabled {
color: #800;
}
span.admin-enabled {
color: #080;
}
span.admin-missing {
color: #f00;
}

Any color changes must consider all four.

Bojhan’s picture

Agreed, required, missing should be red.

mitron’s picture

@Bojhan: Did you mean should NOT be red?

yesct’s picture

I think he is saying that if something is required, but missing, that missing should be in red.

klonos’s picture

Yes, only required + missing should be red.

mitron’s picture

StatusFileSize
new361 bytes

Here is a proposed patch that changes just the color of the word "disabled" to gray (#666).

mitron’s picture

Status: Active » Needs review
mitron’s picture

StatusFileSize
new27.03 KB

Screen shot for patch in #9.
Screen Shot 2013-02-22 at 16.24.53.png

yesct’s picture

Instead of changing the color of disabled to the same color of the surrounding text, lets remove the special css for that class.

I tested it manually, and the screenshot in #11 is still what this looks like.

mitron’s picture

Manually tested patch in #12. It looks like screen shot in #11 on OS-X in Chrome, Firefox, and Safari.

rootwork’s picture

Do we need more reviews before this can be marked RTBC?

tr’s picture

StatusFileSize
new385 bytes

I rerolled the patch for the current version of D8.

I think this is in general a good idea but in D8, unlike D7, all the Required/Required by notation is hidden by default. In D7, all those red "disabled" gave the impression of lots of problems on the site. In D8, you don't see any Required/Required by unless you expand the module description, which has to be done one module at a time. Consequently, there is no overall impression of a problem if this patch isn't committed. So I don't think this is extremely important, just nice to have.

One thing I DO think is important is that the red "missing" designation should be a link to the project page where you can acquire the missing module. It makes no sense to me to highlight a problem like a "missing" module but provide no way to solve that problem. If others agree, I will provide a patch to add this feature. Or, maybe that should be the subject of a different issue.

tr’s picture

Issue summary: View changes

Updated issue summary to remove incorrect related issue. still need to find the issue about the modules page in general.

rootwork’s picture

@TR I love that idea, of providing a link to the missing module.

rootwork’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +SprintWeekend2014
StatusFileSize
new19.12 KB
new19.05 KB

I tested this and it applies and addresses the issue.

Without patch:
Screenshot without the patch

With patch:
Screenshot with the patch

While I still think linking to a missing module page would be nice, that's a separate issue. I'd like to see this committed and backported to 7, since it easily fixes a usability issue. I just now was helping someone (on Drupal 7) who was confused that a module he was using was disabled (he interpreted the red text to mean error) when in fact it was dependent modules of the one he was using that simply weren't enabled.

I get that this is less of an issue on Drupal 8, but since this text (disabled) does not represent an error, there's no reason for it to be colored red.

klonos’s picture

I still think linking to a missing module page would be nice, that's a separate issue...

There you go ;)

rootwork’s picture

Perfect!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.