Introduce a generic entity bundle filter handler

There are just nitpicks:

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/EntityType.phpundefined
@@ -0,0 +1,85 @@
+ * Definition of views_handler_filter_entity_bundle

ups :)

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/EntityType.phpundefined
@@ -0,0 +1,85 @@
+  public $entityType;
...
+  public $entityInfo;

This should be better protected

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/EntityType.phpundefined
@@ -0,0 +1,85 @@
+    // Set the entity type from the definition data, if it's there.
+    if (isset($this->definition['entity_type'])) {
+      $this->entityType = $this->definition['entity_type'];
+    }

Should we just ignore it, if it's not needed/used here?

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/EntityType.phpundefined
@@ -0,0 +1,85 @@
+        $options[$type] = t($info['label']);

Isn't the label already runned through t()?

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/EntityType.phpundefined
@@ -0,0 +1,85 @@
+    $this->ensureMyTable();

A comment might be helpful.

Ups

+++ b/core/modules/system/tests/modules/entity_test/lib/Drupal/entity_test/Plugin/Core/Entity/EntityTest.phpundefined
@@ -64,6 +73,13 @@ class EntityTest extends EntityNG {
+   * The bundle type.

You might be able to improve that comment.

Additional isn't the type a scalar value, like "test_1" aka. a string?

+++ b/core/modules/views/lib/Drupal/views/Tests/Entity/FilterEntityTest.phpundefined
@@ -0,0 +1,99 @@
+class FilterEntityTest extends ViewTestBase {

I'm wondering whether we could use unit tests for that.

+++ b/core/modules/views/lib/Drupal/views/Tests/Entity/FilterEntityTest.phpundefined
@@ -0,0 +1,99 @@
+   * @todo.

He, at least that's honest :)

Let's get that in, we have tests.

We can always try to rework existing tests to use DrupalUnitTests

Why are you calling the bundle filter entity type filter? You are not filtering on entity type (that wouldn't make any sense!)

Sorry x-post but also , IMO this is CNW.

Noone knows yet what will happen if we have proper typed data support in views, but for now this looks really good!

Fix title

That's great.( I almost got a heart attack from the earlier title thinking Views invented some super base that can be filtered on entity type. Phew.)

So that's what people always wanted to have: support for UNION.

Looks great. I had to write one of these in Drupal 7 for a custom entity type and couldn't believe it didn't exist there. Committed/pushed to 8.x.

This was never retested after #1822458: Move dynamic parts (view modes, bundles) out of entity_info(), and broke HEAD.

git revert 44cedfa

Rolled back.

I guess we can move that back to RTBC?

#29: 1891214-29.patch queued for re-testing.

Let's try that again. Committed/pushed to 8.x.