I am using cosign module and would like to suggest that the permissions be 'administer users' since this module is used for authentication. Access administrative pages is too broad.

Comments

ghankstef’s picture

Here is a patch

kevinchampion’s picture

Assigned: Unassigned » kevinchampion
Status: Active » Fixed

That makes sense.

Thanks for the patch - it's been applied to the 7.x-1.x-dev branch.

mlhess’s picture

Status: Fixed » Needs review

I am not sure this is a good idea. This page a site config page. It has nothing to do with users, but how users authenticate to the system.

kevinchampion’s picture

Ok. Should we just create a cosign specific permission then? I can see how 'access administration pages' could be problematic for a site config.

mlhess’s picture

I don't mind that. However, look at the options on that page, it is really a site admin type config options.

@ghankstef, Can you give your use case for someone having access to these options, but not having access admin pages?

kevinchampion’s picture

Isn't the issue rather that someone who has access to the administration pages maybe shouldn't also have access to cosign configuration? I read the permission change as this scenario, and not that someone should be able to access the settings who doesn't have access to admin pages.

I can see a scenario where you have advanced content managers who you want to be able to access the administration pages and help, but do not want to give them the permission to edit the cosign settings.

Either way, I suspect it's best to just create a new permission to allow for the degree of granularity @ghankstef and others may desire.

mlhess’s picture

Sounds good.

kevinchampion’s picture

Status: Needs review » Fixed
StatusFileSize
new1.55 KB

Here are the changes, which I've committed to the 7.x-1.x-dev branch.

ghankstef’s picture

access admin pages is really broad so a separate cosign admin permission is great.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.