Closed (fixed)
Project:
cosign
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
17 Jan 2013 at 21:33 UTC
Updated:
4 Feb 2013 at 16:40 UTC
Jump to comment: Most recent file
I am using cosign module and would like to suggest that the permissions be 'administer users' since this module is used for authentication. Access administrative pages is too broad.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | Add_cosign_permission-1891682-6.patch | 1.55 KB | kevinchampion |
| #1 | cosign-auth-1891682-change-access-callback.patch | 469 bytes | ghankstef |
Comments
Comment #1
ghankstef commentedHere is a patch
Comment #2
kevinchampion commentedThat makes sense.
Thanks for the patch - it's been applied to the 7.x-1.x-dev branch.
Comment #3
mlhess commentedI am not sure this is a good idea. This page a site config page. It has nothing to do with users, but how users authenticate to the system.
Comment #4
kevinchampion commentedOk. Should we just create a cosign specific permission then? I can see how 'access administration pages' could be problematic for a site config.
Comment #5
mlhess commentedI don't mind that. However, look at the options on that page, it is really a site admin type config options.
@ghankstef, Can you give your use case for someone having access to these options, but not having access admin pages?
Comment #6
kevinchampion commentedIsn't the issue rather that someone who has access to the administration pages maybe shouldn't also have access to cosign configuration? I read the permission change as this scenario, and not that someone should be able to access the settings who doesn't have access to admin pages.
I can see a scenario where you have advanced content managers who you want to be able to access the administration pages and help, but do not want to give them the permission to edit the cosign settings.
Either way, I suspect it's best to just create a new permission to allow for the degree of granularity @ghankstef and others may desire.
Comment #7
mlhess commentedSounds good.
Comment #8
kevinchampion commentedHere are the changes, which I've committed to the 7.x-1.x-dev branch.
Comment #9
ghankstef commentedaccess admin pages is really broad so a separate cosign admin permission is great.