Need DRUPAL_ROOT when rendering CSS include links [#1891802]

I'm trying to bootstrap Drupal from an external script, and to pass a string containing page content to drupal_render_page(). The external script lives in a subfolder of my Drupal install dir.

All is going quite well, except that the page renderer is failing to output any CSS includes in the HTML head. After much hunting, I discovered that the cause was a file_exists() check in drupal_pre_render_styles() that's not prepending DRUPAL_ROOT to the file path.

Attached patch fixes this. After applying, CSS outputs normally, the $styles variable once again gets populated and outputted in html.tpl.php.

Comment	File	Size	Author
#5	pre_render_styles_drupalroot_checkscheme.patch	825 bytes	Jaza
#5
#2	pre_render_styles_drupalroot.patch	838 bytes	Jaza
#2
	pre_render_styles_drupalroot.patch	737 bytes	Jaza

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 January 2013 at 01:20

Status:

Needs review

» Needs work

The last submitted patch, pre_render_styles_drupalroot.patch, failed testing.

Comment #2

Jaza CreditAttribution: Jaza commented 18 January 2013 at 05:37

Status:

Needs work

» Needs review

File	Size
pre_render_styles_drupalroot.patch	838 bytes

hmmm... seems that stylesheet paths can also be passed in stream wrapper form (e.g. color modules passes them in 'public://' form). Prepending DRUPAL_ROOT to such paths doesn't work.

Updated patch attached - doesn't prepend DRUPAL_ROOT if the stylesheet path is in the form 'anystreampath://'. Otherwise unchanged.

Comment #3

marcingy CreditAttribution: marcingy commented 18 January 2013 at 05:49

Status:

Needs review

» Needs work

You should use

$file_path = file_uri_scheme($item['data']) ? $item['data'] :  DRUPAL_ROOT . '/' . $item['data'];;

You might also want to call file_stream_wrapper_valid_scheme.

Comment #4

marcingy CreditAttribution: marcingy commented 18 January 2013 at 05:50

Version:

7.x-dev

» 8.x-dev

Also should be fixed in d8 first.

Comment #5

Jaza CreditAttribution: Jaza commented 22 January 2013 at 11:29

Version:	8.x-dev	» 7.x-dev
Status:	Needs work	» Needs review

File	Size
pre_render_styles_drupalroot_checkscheme.patch	825 bytes

Actually, this bug is not applicable to D8, as this file_exists() check was removed in (see for explanation).

So, this is just a D7 bug - and in my opinion, it is a bug fix and not a new feature or a compatibility-breaker. So, should be committed as a D7 maintenance fix.

Attached patch uses file_uri_scheme() instead of a regex check (per @marcingy in #3), against latest D7.