See #1263884: Avoid redirect field and form injection on entities that have a path but where this makes no sense (like comments): Avoid redirect field and form injection on entities that have a path but where this makes no sense (like comments). Patch to follow.

CommentFileSizeAuthor
#1 issue-1892002.patch431 byteslsolesen

Comments

lsolesen’s picture

lsolesen commented
Status: Active » Needs review
StatusFileSize
new issue-1892002.patch431 bytes
lsolesen’s picture

lsolesen commented
Title: Make sure that redirect module does not inject redirect into form » Make sure that redirect module does not inject redirect into customer profile form
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Works fine for me.

rszrama’s picture

rszrama commented

Do we need to do this for any other entities? I'm unfamiliar with what this redirect property or that module does.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

There are separate issues to do the same for products/orders, see comment #26 in the referenced issue.

rszrama’s picture

rszrama commented
Title: Make sure that redirect module does not inject redirect into customer profile form » Prevent the Redirect module from altering Commerce entity forms.
Status: Reviewed & tested by the community » Fixed

Hah, ok. I'll just commit 'em all then. ; )

I still prefer "opt-in" for expanded functionality between Drupal contribs, but we can at least get this "opt-out" in until the next module doing something similar comes up. : P

Commit, expanded to include all Commerce entity types: http://drupalcode.org/project/commerce.git/commitdiff/c0e4f3a

lsolesen’s picture

lsolesen commented
Status: Fixed » Needs work

You should probably revisit the comments in that commit, I think :)

rszrama’s picture

rszrama commented
Status: Needs work » Fixed

Bah, I thought I had used the generic "entity." : P

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.