sizing of png's in Garland theme

It's an issue with the Javascript generating the new PNGs, which are strangely larger than what they were originally.

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/pngfix/pngf...

var strNewHTML = "<span " + imgID + imgClass + imgTitle
         + " style=\"" + "width:" + img.width + "px; height:" + img.height + "px;" + imgStyle + ";"
         + "filter:progid:DXImageTransform.Microsoft.AlphaImageLoader"
         + "(src=\'" + img.src + "\', sizingMethod='scale');\"></span>" 

Might have to divide the width and height in half or something. Not sure what the issue is. If you find something please let me know!

I think http://drupal.org/node/186375 can solve this problem. Guess we should get that out the door. I'll look at that tonight.

5.x-2.0 is out. Mind testing it?

Wow, it really breaks Minnelli. But it does "work".

this script does not do repeating pngs in css. That's why it breaks garland.

Maybe there should be a setting selection box that lets you choose between the javascript and css pngs fixes. If so, on that page I'd outline what are the shortcomings of each way.

I made an issue for this: http://drupal.org/node/191093

I also just added a feature where you can select which CSS classes to replace.

@jenscbc - I think this error is because of the repeating pngs.

What if you just select "img" for the class to replace? Then it should just do that logo...

Using the img tag by itself, I lose the IEPNGFix: Children of positioned element are unclickable! [object] error. However, the image is still sized wrong.

You can see the difference by using IE and FF at http://beta.wiredbyte.com/drupal

Added an option to choose either to use Javascript or CSS for the replacement. Both methods seem to come to different results. The problem has to be with the underlaying javascript in the replacement in both solutions. Have you tested in other themes?

I copied the CVS code from today, and tried it out. First off, I had to create the file pngfix.js, as I did not have t his file on my server. Then I copied the code for pngfix.module.

Using CSS mode, the logo is displayed with dimensions 285x281. there is no change.
Using JS, its still quite a bit larger, but I cant view the properties of the logo. I confirmed that (at least the JS mode) this is happening with the default drupal logo on the other standard themes that come in 5.3.

Sorry to be a pain... I left JS mode on my test site for you to view if you like. http://beta.wiredbyte.com/drupal

Thanks!

5.x-2.x-dev should come with pngfix.js (see here). I have this setup on http://www.robloach.net and am experiencing the same thing. It's probably the way the script runs through the PNG pixels.

Glad to know I am not going crazy! Thanks for all you've done on this module so far rob, hope we can get it figured out.

5.x-3.x-dev should fix this as the jQuery solution has a bit of Javascript magic going on behind the scenes.