Download & Extend

Theme blocker: Events node has 2 main content regions, one within the other

Project:Drupal Commons
Version:7.x-3.x-dev
Component:Events
Category:bug report
Priority:major
Assigned:jpontani
Status:closed (fixed)
Issue tags:theme blocker

Issue Summary

Events node has 2 main content regions, one within the other. this makes the main column 66% of 66% of the page. the regions need to be cleaned up.

screenshot

AttachmentSize
Screenshot_1_18_13_1_58_PM.jpeg203.41 KB

Comments

#1

Assigned to:Anonymous» jpontani

#2

Status:active» needs review

The issue is that there is a fallback context on node/%node page manager. Events does it's own panelized page, and is thus calling both the Events page handler, as well as the Fallback handler, and doing a 66/33 layout twice.

As far as I can tell, there is no need for the fallback handler as nothing is being displayed in the right (33%) panel, and only the existing node content is being displayed in the left (66%) panel.

Attached a patch that removes the fallback handler.

AttachmentSize
1892676.commons_misc.delete_fallback_page_context.2.patch 3.68 KB

#3

Status:needs review» fixed

Instead of #2, switched to full page override for Event node panelizer page. Tested with the fallback context enabled and it works for me.

http://drupalcode.org/project/commons_events.git/commit/eb8b463

#4

Status:fixed» needs work

This needs to be rendered as node content instead of rendered node. The attached screenshot is the settings from post content type that works.

screenshot

AttachmentSize
Screenshot_1_18_13_4_35_PM.jpeg 74.54 KB

#5

To be consistent with the other content types, the Panelizer config for events should be their own feature but I'm fine with that being a separate "minor" issue as a followup.

#6

Status:needs work» fixed

Committed a fix. I will make a new issue to move the panelizer config into a separate sub-module.

http://drupalcode.org/project/commons_events.git/commitdiff/c0db4f7

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.