Patch attached.

I'm myself not sure if "My edited content" is a good string, but My edits is difficult to translate and does not describe what the listing shows. The listing shows the content I have edited, what seems to have been a title in past, but has been changed for reasons I'm not aware of.

CommentFileSizeAuthor
#8 workbench_Translatable+string+review-8.patch9.19 KBbbinkovitz
#3 Screen Shot 2013-01-21 at 4.25.58 PM.png190.49 KBbbinkovitz
workbench_Translatable+string+review.patch8.43 KBhass

Comments

hass’s picture

hass commented
Issue summary: View changes

Updated issue summary.

bbinkovitz’s picture

bbinkovitz commented

Into what languages is translation of "my edited content" easier than "my edits"?

It seems like the bulk of the changes in this patch involve a transformation from title case to sentence case, which I'm not sure is warranted.

hass’s picture

hass commented

Ucfirst rule is documented in #421118: [Meta] Standardize capitalization on actions.

"My edits" has no meaning at all. Additional it is totally wrong. The table below shows "Content I have edited" and not "my edits". I may have edited a revision in many revisions of a node, but it does not list MY edits. In german we need more context.

bbinkovitz’s picture

bbinkovitz commented
StatusFileSize
new Screen Shot 2013-01-21 at 4.25.58 PM.png190.49 KB

Achso, Sie haben Recht.

I am trying to test your patch but I am not able to see changes where I would expect them. Can you post before/after screenshots? I've applied your patch, cc'd all and rr'd and everything, but I don't see the expected changes.

hass’s picture

hass commented

Können wir uns darauf einigen, das "Meine Änderungen" oder "Meine Anpassungen" echt mieses deutsch ist, aber eine aubere Übersetzung ist, die trotzdem nix damit gemein hat, was die Tabelle darunter anzeigt? Im Gegensatz zu "Inhalt, den ich bearbeitet habe". Genauso wie "edit" immer in "Bearbeiten" übersetzt werden muss, "Edit" aber eine klare Trennung zwischen den Worten aufzeigt und "Save | Edit | View" im Gegensatz zu "save | edit | view" auch im englischen besser ist.

bbinkovitz’s picture

bbinkovitz commented

Yes, we agree about that, but I am having trouble with your patch. It seems to apply correctly in the command line, but when I look at my GUI I don't see the changes.

I would also like to communicate in English as much as possible in the issue queue so that the module maintainers can read it.

hass’s picture

hass commented

Clear all caches, please.

bbinkovitz’s picture

bbinkovitz commented

I have cleared caches and rebuilt the registry, as well as running db updates for good measure. I have tried it in two different browsers and cleared browser caches.

bbinkovitz’s picture

bbinkovitz commented
StatusFileSize
new workbench_Translatable+string+review-8.patch9.19 KB

Patch wouldn't apply to latest dev. Rerolled. It looks good.

hass’s picture

hass commented
Status: Needs review » Needs work
bbinkovitz’s picture

bbinkovitz commented

Why was this changed to 'needs work'?

hass’s picture

hass commented

Need to change some strings.

hass’s picture

hass commented
Issue summary: View changes

Updated issue summary.