Closed (fixed)
Project:
Uniqueness
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
19 Jan 2013 at 13:59 UTC
Updated:
2 Feb 2013 at 15:40 UTC
Jump to comment: Most recent file
Currently the fieldset is collapsible/expanded. Instead start with the fieldset collapsed. There is no need to bother the use with similar content if there isn't any (i.e. entering a unique content). Expand the fieldset when there is similar content to display. Only do this once so that if they've manually collapsed it, the widget doesn't fight them.
For my use case, this is pretty important to a good UX.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | uniqueness-autopen_fieldset-1893190-3.patch | 2.6 KB | danchadwick |
| #1 | uniqueness-autopen_fieldset-1893190-1.patch | 1.79 KB | danchadwick |
Comments
Comment #1
danchadwick commentedDue to overall indentation in jQuery Initialization, this patch must be applied second.
Comment #2
bforchhammer commentedChange makes perfect sense to me. Patch needs a reroll, with #1892868: jQuery code not protected from multiple initialization by behavior having been committed.
Comment #3
danchadwick commentedThere was an indentation error introduced in the else clause in the update function. I suspect this is why the patch wouldn't apply.
This re-roll fixes that indentation and re-applies the patch.
Comment #4
danchadwick commentedAnd because that indentation affects the line of code changed in the unpublished content issue, this patch should be applied before that one, which may need a re-roll (we'll have to wait and see).
Comment #5
bforchhammer commentedThanks. I ended up fixing the indentation separately and committed #1.