Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Jan 2013 at 15:04 UTC
Updated:
20 Apr 2013 at 10:25 UTC
Geofield Widget to fill Addressfield with reverse geocoding.
git clone --recursive --branch master git.drupal.org:sandbox/nodoxi/1893210.git
http://drupal.org/node/1893210
Drupal 7
Comments
Comment #1
abhijeetkalsi commentedManual Review :
1) Please add a README.txt file which decribe your mudole information.
2) Your code repository is in "master" branch, please move to custom branch like "7-x.1-0"
Also check your space and formating errors in
http://ventral.org/pareview/httpgitdrupalorgsandboxnodoxi1893210git
Comment #2
cloudbull commentedHi,
You seems have quiet lots of error about formatting, please reference http://ventral.org/pareview/httpgitdrupalorgsandboxnodoxi1893210git
Description:
Please explain more about your project.
Manual review:
Please remove from .info
; Information added by drupal.org packaging script on 2012-11-07^M
version = "7.x-1.0-beta"^M
project = "reverse_geocode_widget"^M
datestamp = "1352313404"
Seems you are using windows based editor and directly to git ? Delete ^M plx
Module logic looks ok.
Thanks
Keith
Comment #3
nodoxi commentedREADME.txt edited
added description and screenshot
Code cleaned and checked with Coder
http://ventral.org/pareview/httpgitdrupalorgsandboxnodoxi1893210git
Comment #4
heddnThere is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
You are working out of a version specific branch. You should really be working out of a 7.x-2.x branch. The branch name you are using is really a tag name.
Please provide a link to the project page.
Manual Review
Your README and project page should make note that usage of this module without some type of cron run to delete the data out of the field would be in direct violation of the terms of use policy from Google. In general, I think that isn't a reasonable activity for any site and would question the validity of this module. See: https://developers.google.com/maps/terms.
Comment #5
monymirzaComment #6
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application.
I'm a robot and this is an automated message from Project Applications Scraper.