Geofield Widget to fill Addressfield with reverse geocoding.

git clone --recursive --branch master git.drupal.org:sandbox/nodoxi/1893210.git
http://drupal.org/node/1893210

Drupal 7

Comments

abhijeetkalsi’s picture

Status: Needs review » Needs work

Manual Review :

1) Please add a README.txt file which decribe your mudole information.
2) Your code repository is in "master" branch, please move to custom branch like "7-x.1-0"

Also check your space and formating errors in
http://ventral.org/pareview/httpgitdrupalorgsandboxnodoxi1893210git

cloudbull’s picture

Hi,

You seems have quiet lots of error about formatting, please reference http://ventral.org/pareview/httpgitdrupalorgsandboxnodoxi1893210git

Description:

Please explain more about your project.

Manual review:

Please remove from .info

; Information added by drupal.org packaging script on 2012-11-07^M
version = "7.x-1.0-beta"^M
project = "reverse_geocode_widget"^M
datestamp = "1352313404"

Seems you are using windows based editor and directly to git ? Delete ^M plx

Module logic looks ok.

Thanks
Keith

nodoxi’s picture

Status: Needs work » Needs review

README.txt edited
added description and screenshot
Code cleaned and checked with Coder
http://ventral.org/pareview/httpgitdrupalorgsandboxnodoxi1893210git

heddn’s picture

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732

You are working out of a version specific branch. You should really be working out of a 7.x-2.x branch. The branch name you are using is really a tag name.

Please provide a link to the project page.

Manual Review

Your README and project page should make note that usage of this module without some type of cron run to delete the data out of the field would be in direct violation of the terms of use policy from Google. In general, I think that isn't a reasonable activity for any site and would question the validity of this module. See: https://developers.google.com/maps/terms.

10.1.3 Restrictions against Data Export or Copying.
(b) No Pre-Fetching, Caching, or Storage of Content. You must not pre-fetch, cache, or store any Content, except that you may store: (i) limited amounts of Content for the purpose of improving the performance of your Maps API Implementation if you do so temporarily (and in no event for more than 30 calendar days), securely, and in a manner that does not permit use of the Content outside of the Service; and (ii) any content identifier or key that the Maps APIs Documentation specifically permits you to store. For example, you must not use the Content to create an independent database of "places" or other local listings information.
monymirza’s picture

Status: Needs review » Needs work
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.