About Project
SLiMS module is drupal module for integrating with OPAC (Online Public Access Catalog) application of SLiMS (Senayan Library Management System).

This module can display biblio items and search items entire catalog.

Download SLiMS application at http://slims.web.id/
SLiMS Application Demo at http://slims.web.id/demo/

Project Page
http://drupal.org/sandbox/sutriadi/1877312

git clone --recursive --branch 7.x-1.x sutriadi@git.drupal.org:sandbox/sutriadi/1877312.git slims

Comments

miloyz’s picture

Status: Needs review » Needs work

Hi sutriadi,

Thanks very much for submitting this very interesting module.

Please find below an initial automated review mostly from from PAReview and it seems there are quite a few errors for you to fix already:

Master branch
You are working on master branch, please switch to a 7.x-1.x branch and delete the master.
Could you please set the 7.x-1.x branch as default and remove the master branch?

Project page
Your project page is not very detailed, please have a look at the tips for a great project page, you may also use HTML-tags for better structure.
Screenshots could also be a good idea to make things easier to understand for some users.

Automated review
PAReview code validation prompted errors:
http://ventral.org/pareview/httpgitdrupalorgsandboxsutriadi1877312git-7x-1x
Please fix the validation errors as indicated.

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxsutriadi1877312git-7x-1x.

LICENSE.txt
Please remove the LICENSE.txt file. Drupal.org will add the appropriate version automatically during packaging so your repository should not include it.
See file: LICENSE.txt

So far, that's all I could find, but I think we should be giving this project more reviews after these issues have been fixed.

Feel free to let me know if you would have questions, comments or concerns on these items, I would surely be glad to provide more information.

Hope that helps getting module's review started.
Cheers!

sutriadi’s picture

fixed all except description of project page. thank you for review.

eule’s picture

Manual Review

The README.txt is not proper . Check http://drupal.org/node/161085 Please Provide Overview in English
The project page is quite messed up. Please add categorized description. see http://drupal.org/node/997024

Code looks good! Get Your Review Bonus

Good Luck and Thanks for your Work.

sutriadi’s picture

Status: Needs work » Needs review

I've changed README.txt and added some information on project page also.

cackle’s picture

Hello,

git clone --recursive --branch 7.x-1.x sutriadi@git.drupal.org:sandbox/sutriadi/1877312.git slims

1. Your git command is incorrect. Please check it.
2. line 462 - function theme_slims_div_items(): this function generate a lot of html. Presentation must be separated from functionality. Html should refactored out of the class body into theming-hooks.

cackle’s picture

Status: Needs review » Needs work
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.