Download & Extend
Edit » Issues

Links don't work after toggling edit/view mode

Posted by webchick on January 20, 2013 at 10:01am
Project:Edit
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Edit D7 Backport

Issue Summary

To reproduce, toggle edit mode, then toggle back to view mode, then try and click a link. You can't. The universe's cruelest joke.

Login or register to post comments

Comments

#1

Posted by nod_ on January 20, 2013 at 10:09am
Title:Toggling edit/view mode doesn't work» Links don't work after toggling edit/view mode

#2

Posted by nod_ on January 20, 2013 at 2:23pm

Problem is in editingWidgets/*widget.js files, there is a preventDefault on click event that is bound but never released.

#3

Posted by Wim Leers on January 21, 2013 at 11:30am

If so, then that bug is most likely also in D8, so I'll port it over to 8.

#4

Posted by nod_ on January 21, 2013 at 4:58pm
Priority:major» critical

#5

Posted by Wim Leers on January 21, 2013 at 8:13pm

Confirmed that this is also a bug in Drupal 8. Funny that nobody reported this yet.

#6

Posted by nod_ on January 21, 2013 at 10:08pm
Status:active» needs review

Nailed it.

There is a problem when the page opens with #edit but that should be solvable. I'll look into it tomorrow.

#7

Posted by Wim Leers on January 22, 2013 at 9:57am

I wonder if this is related to the lazy loading of editors.

#8

Posted by nod_ on January 22, 2013 at 10:01am

I'd be surprised. It's all happening in app.js which is present on page load.

#9

Posted by nod_ on January 22, 2013 at 10:45am

Comes down to a createjs issue https://github.com/bergie/create/issues/133

#10

Posted by nod_ on January 22, 2013 at 11:43am
Status:needs review» fixed

Ok this one is solved but I made another more tricky bug appear, see #1895458: Duplicate data-edit-id attribute for node title.

#11

Posted by Wim Leers on January 30, 2013 at 7:43pm

How did you solve this without fixing the upstream Create.js problem?

#12

Posted by nod_ on January 30, 2013 at 9:51pm

with http://drupalcode.org/project/edit.git/commitdiff/1fec4426e4c9c47c1d7990... and http://drupalcode.org/project/edit.git/commitdiff/f8310b952c495aee4f9e63...

I changed _manageDocumentFocus to be called later (app.js#l117) and did the binding in there. Unbinding is in _releaseDocumentFocusManagement.

#13

Posted by System Message on February 13, 2013 at 10:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here