SearchblockThis simple module provides a block with a searchform to search in Google, Bing, Yahoo!, Alta Vista or Dogpile.

Upload files to /sites/all/modules/searchblock/ and activate the module. You should find the block in the block section.

No configuration is required, but you can add descriptional text, select the result to be displayed in the same browser window or in a new one. You can also choose whether you want the search engine option in a drop down menu or radio buttons. The default text on the searchbutton is "Search", but you also have the option to change it.

The module is for Drupal 7.

Link to Sandbox page: http://drupal.org/sandbox/pkPlus/1893704
Link to GIT: http://drupalcode.org/sandbox/pkPlus/1893704.git
Link to Drupalcode tree: http://drupalcode.org/sandbox/pkPlus/1893704.git/tree

Live example: http://www.internor.com/content/searchblock-drupal

Comments

pkPlus’s picture

pkPlus commented
Issue summary: View changes

Image added.

pkPlus’s picture

pkPlus commented
Issue summary: View changes

Added link to Drupalcode tree

pkPlus’s picture

pkPlus commented
Issue summary: View changes

Added pathname to upload directory

pkPlus’s picture

pkPlus commented
Issue summary: View changes

Paddint on image

pkPlus’s picture

pkPlus commented
Issue summary: View changes

Changed description text

nikro’s picture

nikro commented

Hi pkPlus,

I'll just give you a quick heads up. I'm not sure if that's a module someone would need, but if you really want to continue it's development, would be awesome of people would be able to specify engines that they want to enable, in the configuration form.

Automated Review

Make sure you get no errors and no warnings (you can re-run the test via Repeat Review):
http://ventral.org/pareview/httpgitdrupalorgsandboxpkplus1893704git

Manual Review

searchblock_block.js
You have to rewrite the functionality, take a look at: http://drupal.org/node/171213
Use jQuery to add behavior to your search block, instead of calling the function directly onclick.

searchblock_block.module
All-in-all I'd recommend you to use Form API instead of outputting a
in your theme function. Users will be able to add custom functionality to your form, preprocess and process functions, etc.
I'm not aware right now of a module with similar functionality (I didn't search really intense thou'), but if your module can be used as a standalone module, consider making it a bit more dynamic in the future.

Keep up the good work, cheers!

nikro’s picture

nikro commented
Status: Needs review » Needs work

I have to stop forgetting to change statuses!

nikro’s picture

nikro commented

Also make sure you get rid of the master branch, follow these instructions: http://drupal.org/node/1127732

pkPlus’s picture

pkPlus commented

Hi Nikro

Thank you for reviewing this and thank you very much for more great advices and tips. This is my first attempt to create a module, so I have a lot to learn. I appreciate your advices and will dive into the matter and do something with what you pointed out.

I'm working on developing a bookmarking site, where users can choose which bookmarks they want on their own custom page. At the same time, I thought it might be nice for users to have a search box where they can select what search engine to use. I found no modules for that, so I gave it a try myself.

Thanks a lot! :)

arun ak’s picture

arun ak commented

Hi,

In your module js file add drupal js behaviour.

chris.smith’s picture

chris.smith commented
Status: Needs work » Reviewed & tested by the community
  • In the configuration file I found the typo 'Show result in same browserwindow or open in new'
  • Module looks good!
stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Reviewed & tested by the community » Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away.
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

PA robot commented
Issue summary: View changes

Added link to example